From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E013C433FE for ; Fri, 11 Dec 2020 17:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECF6A23DC2 for ; Fri, 11 Dec 2020 17:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405232AbgLKQ25 (ORCPT ); Fri, 11 Dec 2020 11:28:57 -0500 Received: from linux.microsoft.com ([13.77.154.182]:54224 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395153AbgLKQ2Z (ORCPT ); Fri, 11 Dec 2020 11:28:25 -0500 Received: from [192.168.0.104] (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 8FDB120B717A; Fri, 11 Dec 2020 08:27:44 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8FDB120B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1607704064; bh=ghhwTCKzUyzBuV9Ol4jB1Kk7JTxsBVEU1FEuL6OBZqI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=bYm81nVRNFLJCOUD3nU2g3EPeAwM7yK2qWOhvVWpORfguzdsiC4R3aaW0/IYpeuLl wu0uusHuI0oKHKL3WrIzKUh8odyaPRYdyEa8h0YXJQKLWZLGcUjVZ/HMLQzaz9thKz 5n7nt+mo2Zp7g6IdTXi9xaHoI3yYbrY8HxyY/r0Y= Subject: Re: [PATCH v7 8/8] selinux: include a consumer of the new IMA critical data hook To: Tyler Hicks , Tushar Sugandhi Cc: zohar@linux.ibm.com, stephen.smalley.work@gmail.com, casey@schaufler-ca.com, agk@redhat.com, snitzer@redhat.com, gmazyland@gmail.com, paul@paul-moore.com, sashal@kernel.org, jmorris@namei.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com References: <20201209194212.5131-1-tusharsu@linux.microsoft.com> <20201209194212.5131-9-tusharsu@linux.microsoft.com> <20201211153618.GA4951@sequoia> <20201211154156.GB4951@sequoia> From: Lakshmi Ramasubramanian Message-ID: <27bce16a-9e95-2559-af37-b47b81bdcd2e@linux.microsoft.com> Date: Fri, 11 Dec 2020 08:27:44 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201211154156.GB4951@sequoia> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On 12/11/20 7:41 AM, Tyler Hicks wrote: > On 2020-12-11 09:36:30, Tyler Hicks wrote: >> The calls to pr_err() in this aren't quite following the style of the >> other error SELinux error messages. > > Sorry, I left out a word. I meant to say that the calls to pr_err() in > this *file* aren't quite following the right style. Please adjust all of > them. > > Thanks! > Thanks for reviewing the patch Tyler. I'll make the changes per your comments. -lakshmi