From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4F75376BD6 for ; Thu, 5 Mar 2026 10:53:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707995; cv=none; b=LFuiK4lDm9RyVO4c5JHPfBT5jIthqMzqfRl8abwH+gJ4KV7h5kzVM4o0hQMCFx7BqQ3QAiytW9sVKP/RhdaT3Ey9OWWRk5xUSPEN8mqbkm6z2InubHJbajKAFWwlw6Y9umtDqcVsx3/rzZ46svXTjaXza5yHib0XZ2NwWhE8JlI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772707995; c=relaxed/simple; bh=mPbvlwWoHj85GU1f61A/6Cc0J7NgRVi2gqMqeKSpzeo=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version:Date: Message-ID:Content-Type; b=WQdvzOdw3/S3nDmCNA+qnYabzR63x8fwtnTPBn2XUYWvLCOMIQ/PR9BgTjADZthFRQsCup5OWBq9jZMnbtYt8QeY8Pk8tDNgDKMqRAKZj30wYG6z1Vo1qkkG8eJCtPVLF34PxJuCofssDuNpgawA+YXHd2DBiM8HKd2oY51BwP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bio7EmUO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bio7EmUO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772707992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YNDCNkMCVOkvdHpTSgzP1GUBuRyBR5Q0ZRMeQkfNaBU=; b=Bio7EmUOQEYdNMgtVe8NdtIdQ+JSxPpz3u5RLOFbU5h2heooN3Z6GxkRF3AYoI+ZZ6hyec 8jTtn0eEQKZmjSZG2bZAVRxuSgFH/v4CdctkqjN6Z9W0fJQxzUe2RXykz5N3jtWDApmwAg Yjfmpk/H75DhC/2688Tp0HidZPQqTPM= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-391-G2eoyCM-MW29ZhCAlPKaPA-1; Thu, 05 Mar 2026 05:53:08 -0500 X-MC-Unique: G2eoyCM-MW29ZhCAlPKaPA-1 X-Mimecast-MFC-AGG-ID: G2eoyCM-MW29ZhCAlPKaPA_1772707983 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C35A1956089; Thu, 5 Mar 2026 10:53:02 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.44.32.194]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 63BBD1800671; Thu, 5 Mar 2026 10:52:49 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20260305-module-signature-uapi-v3-3-92f45ea6028c@linutronix.de> References: <20260305-module-signature-uapi-v3-3-92f45ea6028c@linutronix.de> <20260305-module-signature-uapi-v3-0-92f45ea6028c@linutronix.de> To: =?us-ascii?Q?=3D=3Futf-8=3Fq=3FThomas=5FWei=3DC3=3D9Fschuh=3F=3D?= Cc: David Howells , David Woodhouse , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Paul Moore , James Morris , "Serge E. Hallyn" , Nathan Chancellor , Nicolas Schier , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org, linux-s390@vger.kernel.org, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kbuild@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 3/8] module: Give 'enum pkey_id_type' a more specific name Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Thu, 05 Mar 2026 10:52:47 +0000 Message-ID: <287135.1772707967@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: cHPV5tD0lvbYd9d2k64z1Wffp2Od42hi1HYUqdm58Iw_1772707983 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Thomas Wei=C3=9Fschuh wrote: > -enum pkey_id_type { > -=09PKEY_ID_PKCS7 =3D 2,=09/* Signature in PKCS#7 message */ > +enum module_signature_type { > +=09MODULE_SIGNATURE_TYPE_PKCS7 =3D 2,=09/* Signature in PKCS#7 message *= / > }; It might be best to just kill the enum and replace it with a single #define= . David