From: David Howells <dhowells@redhat.com>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: dhowells@redhat.com, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org, jmorris@namei.org,
serge@hallyn.com, linux-kernel@lists.codethink.co.uk
Subject: Re: [PATCH] keys: fix missing __user in KEYCTL_PKEY_QUERY
Date: Tue, 05 Mar 2019 07:41:54 +0000 [thread overview]
Message-ID: <29870.1551771714@warthog.procyon.org.uk> (raw)
In-Reply-To: <20190301113026.17721-1-ben.dooks@codethink.co.uk>
Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> The arg5 of KEYCTL_PKEY_QUERY should have a __user pointer tag on
> it as it is a user pointer. This clears the following sparse warning
> for this:
>
> security/keys/keyctl.c:1755:43: warning: incorrect type in argument 3 (different address spaces)
> security/keys/keyctl.c:1755:43: expected struct keyctl_pkey_query [noderef] <asn:1>*<noident>
> security/keys/keyctl.c:1755:43: got struct keyctl_pkey_query *<noident>
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2019-03-05 7:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 11:30 [PATCH] keys: fix missing __user in KEYCTL_PKEY_QUERY Ben Dooks
2019-03-01 22:28 ` Serge E. Hallyn
2019-03-05 3:28 ` James Morris
2019-03-05 7:41 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29870.1551771714@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=ben.dooks@codethink.co.uk \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).