From: David Howells <dhowells@redhat.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: dhowells@redhat.com, "Darrick J. Wong" <darrick.wong@oracle.com>,
viro@zeniv.linux.org.uk, raven@themaw.net,
linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org,
linux-block@vger.kernel.org, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/13] uapi: General notification ring definitions [ver #4]
Date: Thu, 13 Jun 2019 14:34:45 +0100 [thread overview]
Message-ID: <30226.1560432885@warthog.procyon.org.uk> (raw)
In-Reply-To: <6b6f5bb0-1426-239b-ac9f-281e31ddcd04@infradead.org>
Randy Dunlap <rdunlap@infradead.org> wrote:
> What is the problem with inline functions in UAPI headers?
It makes compiler problems more likely; it increases the potential for name
collisions with userspace; it makes for more potential problems if the headers
are imported into some other language; and it's not easy to fix a bug in one
if userspace uses it, just in case fixing the bug breaks userspace.
Further, in this case, the first of Darrick's functions (calculating the
length) is probably reasonable, but the second is not. It should crank the
tail pointer and then use that, but that requires
> >> Also, weird multiline comment style.
> >
> > Not really.
>
> Yes really.
No. It's not weird. If anything, the default style is less good for several
reasons. I'm going to deal with this separately as I need to generate some
stats first.
David
next prev parent reply other threads:[~2019-06-13 15:13 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 14:17 [RFC][PATCH 00/13] Mount, FS, Block and Keyrings notifications [ver #4] David Howells
2019-06-07 14:17 ` [PATCH 01/13] security: Override creds in __fput() with last fputter's creds " David Howells
2019-06-07 14:17 ` [PATCH 02/13] uapi: General notification ring definitions " David Howells
2019-06-07 15:12 ` Darrick J. Wong
2019-06-07 15:30 ` David Howells
2019-06-07 15:51 ` David Howells
2019-06-09 4:35 ` Randy Dunlap
2019-06-13 13:34 ` David Howells [this message]
2019-06-13 14:49 ` Randy Dunlap
2019-06-07 14:17 ` [PATCH 03/13] security: Add hooks to rule on setting a watch " David Howells
2019-06-07 14:17 ` [PATCH 04/13] security: Add a hook for the point of notification insertion " David Howells
2019-06-07 14:18 ` [PATCH 05/13] General notification queue with user mmap()'able ring buffer " David Howells
2019-06-07 14:18 ` [PATCH 06/13] keys: Add a notification facility " David Howells
2019-06-10 17:11 ` Jonathan Corbet
2019-06-10 17:47 ` David Howells
2019-06-07 14:18 ` [PATCH 07/13] vfs: Add a mount-notification " David Howells
2019-06-07 14:18 ` [PATCH 08/13] vfs: Add superblock notifications " David Howells
2019-06-07 14:18 ` [PATCH 09/13] fsinfo: Export superblock notification counter " David Howells
2019-06-07 14:18 ` [PATCH 10/13] Add a general, global device notification watch list " David Howells
2019-06-07 14:19 ` [PATCH 11/13] block: Add block layer notifications " David Howells
2019-06-07 14:19 ` [PATCH 12/13] usb: Add USB subsystem " David Howells
2019-06-07 14:19 ` [PATCH 13/13] Add sample notification program " David Howells
2019-06-10 15:21 ` [RFC][PATCH 00/13] Mount, FS, Block and Keyrings notifications " Stephen Smalley
2019-06-10 16:33 ` Casey Schaufler
2019-06-10 16:42 ` Andy Lutomirski
2019-06-10 18:01 ` Casey Schaufler
2019-06-10 18:22 ` Andy Lutomirski
2019-06-10 19:33 ` Casey Schaufler
2019-06-10 19:53 ` Andy Lutomirski
2019-06-10 21:25 ` Casey Schaufler
2019-06-11 0:13 ` Andy Lutomirski
2019-06-11 14:32 ` Stephen Smalley
2019-06-12 8:55 ` David Howells
2019-06-10 22:07 ` David Howells
2019-06-11 14:21 ` What do LSMs *actually* need for checks on notifications? David Howells
2019-06-11 15:57 ` Stephen Smalley
2019-06-11 16:22 ` Casey Schaufler
2019-06-12 11:43 ` David Howells
2019-06-13 18:46 ` Stephen Smalley
2019-06-12 17:41 ` David Howells
2019-06-12 18:14 ` Casey Schaufler
2019-06-12 18:36 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30226.1560432885@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=raven@themaw.net \
--cc=rdunlap@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).