From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>,
stephen.smalley.work@gmail.com, casey@schaufler-ca.com
Cc: tyhicks@linux.microsoft.com, tusharsu@linux.microsoft.com,
sashal@kernel.org, jmorris@namei.org,
linux-integrity@vger.kernel.org, selinux@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IMA: Handle early boot data measurement
Date: Tue, 25 Aug 2020 08:46:55 -0700 [thread overview]
Message-ID: <307617de-b42d-ac52-6e9e-9e0d16bbc20e@linux.microsoft.com> (raw)
In-Reply-To: <a7ea2da1f895ee3db4697c00804160acb6db656e.camel@linux.ibm.com>
On 8/25/20 8:40 AM, Mimi Zohar wrote:
> On Fri, 2020-08-21 at 16:12 -0700, Lakshmi Ramasubramanian wrote:
>> The current implementation of early boot measurement in
>> the IMA subsystem is very specific to asymmetric keys. It does not
>> handle early boot measurement of data from other subsystems such as
>> Linux Security Module (LSM), Device-Mapper, etc. As a result data,
>> provided by these subsystems during system boot are not measured by IMA.
>>
>> Update the early boot key measurement to handle any early boot data.
>> Refactor the code from ima_queue_keys.c to a new file ima_queue_data.c.
>> Rename the kernel configuration CONFIG_IMA_QUEUE_EARLY_BOOT_KEYS to
>> CONFIG_IMA_QUEUE_EARLY_BOOT_DATA so it can be used for enabling any
>> early boot data measurement. Since measurement of asymmetric keys is
>> the first consumer of early boot measurement, this kernel configuration
>> is enabled if IMA_MEASURE_ASYMMETRIC_KEYS and SYSTEM_TRUSTED_KEYRING are
>> both enabled.
>>
>> Update the IMA hook ima_measure_critical_data() to utilize early boot
>> measurement support.
>
> Please limit the changes in this patch to renaming the functions and/or
> files. For example, adding "measure_payload_hash" should be a separate
> patch, not hidden here.
>
Thanks for the feedback Mimi.
I'll split this into 2 patches:
PATCH 1: Rename files + rename CONFIG
PATCH 2: Update IMA hook to utilize early boot data measurement.
-lakshmi
next prev parent reply other threads:[~2020-08-25 15:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 23:12 [PATCH] IMA: Handle early boot data measurement Lakshmi Ramasubramanian
2020-08-25 15:40 ` Mimi Zohar
2020-08-25 15:46 ` Lakshmi Ramasubramanian [this message]
2020-08-25 17:42 ` Mimi Zohar
2020-08-25 17:55 ` Lakshmi Ramasubramanian
2020-08-25 18:03 ` Mimi Zohar
2020-08-25 19:35 ` Lakshmi Ramasubramanian
2020-08-25 19:43 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=307617de-b42d-ac52-6e9e-9e0d16bbc20e@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=casey@schaufler-ca.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=tusharsu@linux.microsoft.com \
--cc=tyhicks@linux.microsoft.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).