From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97241D63EF; Thu, 17 Oct 2024 21:16:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729199787; cv=none; b=sT7gdp8xUkQrIgPYJc6NlEtD7iszLclHiPDpxy0Tgdr2xvbdQltBJNG59ElF6oMgwhk/sFDjmQwh+yJZDJhGPVQLrUm66AhHHMbqzrryLjR6LTIZz6vaufjD7LyqEjna4PR9nfmNz9wwXKpHzxY8SXGBVsXXWSg+bNgBvmptRFU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729199787; c=relaxed/simple; bh=e9vuOo0EoJQc1axQfI9B0Mb+dykcnQDHVZZWlsHa0Tg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=sdq/p36BqmjFiQIO+cgrB8hUWFveRr9Hp5E3t0w0+lT26Vy3FsPRJsM/xvbVyollHJ+sgVwCAhjkws1mjy7HCk/vi8zScMDDULMk+iYtsWtkOMc8A4S3I4UcvGAC/Us90IyKSkpOKws1m8B3BAt3uIcqW4avwcXPlC99KO3xUAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W4jG3faB; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W4jG3faB" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E39BC4CEC3; Thu, 17 Oct 2024 21:16:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729199786; bh=e9vuOo0EoJQc1axQfI9B0Mb+dykcnQDHVZZWlsHa0Tg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=W4jG3faB4J2GtSwh55ZU1hOnuR7tLu8Jh2NOXR/TRFw5QtU09Yx60bW2VTx1TfgTv RBHCns0empPYjm5Aiyfp379gfbsulK5nIfyYxSKez7HzGNGZWoQWFYCNkXljWy73Tx uo39nTqxzDnLZE4jHGqVsgl54URuNK9UGGvutK1+V0Dk7v/ozWC+LH2ekzBSNczGdv sFG39jjoKZSSZ/cDE2e8BgDZdAX9ALFy/OmB2IAIIcOBVcgc0/9mItILtI+os2BwW1 cHgvza6mcCITOrIwmfe4JE0xo1AbR4gpVS8EyYH9mSDm/Zpv0n/IVx8Y+wsCoyMTGx 030GIPIcQNYRw== Message-ID: <31abac4eb64404494395ee6ecc7fc697e0cad0af.camel@kernel.org> Subject: Re: [RFC PATCH v3 03/13] clavis: Introduce a new system keyring called clavis From: Jarkko Sakkinen To: Eric Snowberg Cc: "open list:SECURITY SUBSYSTEM" , David Howells , David Woodhouse , "herbert@gondor.apana.org.au" , "davem@davemloft.net" , Ard Biesheuvel , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , =?ISO-8859-1?Q?Micka=EBl_Sala=FCn?= , "casey@schaufler-ca.com" , Stefan Berger , "ebiggers@kernel.org" , Randy Dunlap , open list , "keyrings@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "linux-efi@vger.kernel.org" , "linux-integrity@vger.kernel.org" Date: Fri, 18 Oct 2024 00:16:22 +0300 In-Reply-To: References: <20241017155516.2582369-1-eric.snowberg@oracle.com> <20241017155516.2582369-4-eric.snowberg@oracle.com> <30308614a1229870d205c33deba193f3d6732bef.camel@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.4 (3.52.4-1.fc40) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2024-10-17 at 20:34 +0000, Eric Snowberg wrote: >=20 >=20 > > On Oct 17, 2024, at 10:50=E2=80=AFAM, Jarkko Sakkinen > > wrote: > >=20 > > On Thu, 2024-10-17 at 09:55 -0600, Eric Snowberg wrote: > > > +static struct asymmetric_key_id *clavis_parse_boot_param(char > > > *kid, > > > struct asymmetric_key_id *akid, > > > + int > > > akid_max_len) > > > +{ > > > + int error, hex_len; > > > + > > > + if (!kid) > > > + return 0; > > > + > > > + hex_len =3D strlen(kid) / 2; > >=20 > > Hmmm... I'd consider sanity checking this: > >=20 > > size_t len; > >=20 > > /* ... */ > >=20 > > len =3D strlen(kid); > > if (len % 2) { > > pr_err("Clavis key id has invalid length %lu\n", len); > > return 0; > > } > >=20 > > hex_len =3D len / 2; > >=20 >=20 > Good catch, I will include this in the next round.=C2=A0 I have also adde= d > a kunit test=20 > for this as well.=C2=A0 Thanks. I guess hex2bin() would eventually catch this issue, i.e. not an actual bug, but I still think that you are better off doing also check here and get an appropriate message to klog if that ever happens :-) BR, Jarkko