From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBFC2C433C1 for ; Fri, 26 Mar 2021 16:06:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C8E761A33 for ; Fri, 26 Mar 2021 16:06:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbhCZQFf (ORCPT ); Fri, 26 Mar 2021 12:05:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230046AbhCZQFE (ORCPT ); Fri, 26 Mar 2021 12:05:04 -0400 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 814FFC0613AA for ; Fri, 26 Mar 2021 09:05:04 -0700 (PDT) Received: by mail-io1-xd36.google.com with SMTP id x16so5907931iob.1 for ; Fri, 26 Mar 2021 09:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=DyM8mR09HOKJ3duG1Hs3IbvhPdT50cHIKRPlpFE7bRk=; b=PlYA5g107/q0IhxLnIi5RbaM5Djf85Bg+Sl4JiXyxHE92v43t11ahb3/98iuIBP/Pe J+T+6d0wSQwjUk5Du4ku4tnj21VWQSKwhnELjtJctOIpf8wm9gUtADd2+n2HDdn2H5RG WAaI4xn21XSeBXagAd3GynDsUumcrpZnScuZvhXQP6NsLVhtaAw3zhTeorqdBhGnADB7 r/SMSIas60osEg+jBaKeTCTOaYJr5ZshsqrI9wwFE93aYXUch5H6XfzMrN02wjE7X7Xh xdCpPpXOHmq/HWqvebigcLMzXmyakgMj+33wUVVTFQA9K9tdWGGv04SLKfvktzvWlik6 /r0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DyM8mR09HOKJ3duG1Hs3IbvhPdT50cHIKRPlpFE7bRk=; b=guNW/AcOAoT/K0bITMd5cwPE+n6KRmr85fuNuqFa9X6ZJnxGPJ53XmgFBq4Gb7d+aV 4i0fvnjK53otjoUC3s7OCun9HNBpA++C5D8AuBbiVThGrUXXDCnANWPjjbJWdCVW9wf4 M10U2Oir5wrJk8h4DBsMWbBdmc+MxC7UhxdMrBLf+H3NIfSHnWYeuXfn6n86czl4K3cT kXsk2k/2RMse/q8vy/fVhAMekGYtkOit0ueUjsroXU+mfj3fVf4RHMvlmvLJPUHpaZpA X5WcKx01tusYPxeNFKgL+Pq6HMXlK1ypUXPSD53mVaCUzvFmPxcXi649UYyaV2Tx40gG 62Gg== X-Gm-Message-State: AOAM530/FgfEUDKmecyu9dnDt+br6DinAckj8sgG0LHRqXP2lDE/cA8/ c6tLAa7y4M8SKt020deBddzBNQ== X-Google-Smtp-Source: ABdhPJy2jPnhi1lfH0pmOKxay7TKLFnWV6o+2WfCCLe+1B/ouV+0+Y1D3D1dB2TalTDDXpzTrJ5N0g== X-Received: by 2002:a05:6602:3314:: with SMTP id b20mr11000794ioz.78.1616774704004; Fri, 26 Mar 2021 09:05:04 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id s3sm2897293ilj.77.2021.03.26.09.05.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Mar 2021 09:05:03 -0700 (PDT) Subject: Re: [PATCH] Revert "Smack: Handle io_uring kernel thread privileges" To: Casey Schaufler Cc: linux-security-module@vger.kernel.org, LKML References: <04c7c410-08e8-626a-795e-b77db6666804@kernel.dk> From: Jens Axboe Message-ID: <33fc367c-ec00-eba5-71a9-59e47eb76163@kernel.dk> Date: Fri, 26 Mar 2021 10:05:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On 3/26/21 10:00 AM, Casey Schaufler wrote: > On 3/25/2021 5:42 PM, Jens Axboe wrote: >> This reverts commit 942cb357ae7d9249088e3687ee6a00ed2745a0c7. >> >> The io_uring PF_IO_WORKER threads no longer have PF_KTHREAD set, so no >> need to special case them for credential checks. > > Could you cite the commit making that change? > I wouldn't want to see this change back-ported to a kernel > that doesn't have that change as well. This is strictly 5.12+. The change came about from: commit 3bfe6106693b6b4ba175ad1f929c4660b8f59ca8 Author: Jens Axboe Date: Tue Feb 16 14:15:30 2021 -0700 io-wq: fork worker threads from original task So don't backport it. -- Jens Axboe