From: Paul Moore <paul@paul-moore.com>
To: Masahiro Yamada <masahiroy@kernel.org>,
linux-security-module@vger.kernel.org
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Gomez <da.gomez@samsung.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Ondrej Mosnacek <omosnace@redhat.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
selinux@vger.kernel.org
Subject: Re: [PATCH 2/2] selinux: move genheaders to security/selinux/
Date: Mon, 26 Aug 2024 17:14:41 -0400 [thread overview]
Message-ID: <3447459d08dd7ebb58972129cddf1c44@paul-moore.com> (raw)
In-Reply-To: <20240809122007.1220219-3-masahiroy@kernel.org>
On Aug 9, 2024 Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> This tool is only used in security/selinux/Makefile.
>
> There is no reason to keep it under scripts/.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
> scripts/remove-stale-files | 3 +++
> scripts/selinux/Makefile | 2 +-
> scripts/selinux/genheaders/.gitignore | 2 --
> scripts/selinux/genheaders/Makefile | 3 ---
> security/selinux/.gitignore | 1 +
> security/selinux/Makefile | 7 +++++--
> .../selinux/genheaders => security/selinux}/genheaders.c | 0
> 7 files changed, 10 insertions(+), 8 deletions(-)
> delete mode 100644 scripts/selinux/genheaders/.gitignore
> delete mode 100644 scripts/selinux/genheaders/Makefile
> rename {scripts/selinux/genheaders => security/selinux}/genheaders.c (100%)
As long as there is no harm in keeping genheaders under scripts/selinux,
and based on your cover letter it would appear that there is no problem
with the current location, I would prefer to keep it where it currently
lives.
--
paul-moore.com
next prev parent reply other threads:[~2024-08-26 21:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 12:19 [PATCH 0/2] selinux: Do not include <linux/*.h> from host programs (+ extra clean-up) Masahiro Yamada
2024-08-09 12:19 ` [PATCH 1/2] selinux: do not include <linux/*.h> headers from host programs Masahiro Yamada
2024-08-26 21:14 ` Paul Moore
2024-08-09 12:19 ` [PATCH 2/2] selinux: move genheaders to security/selinux/ Masahiro Yamada
2024-08-26 21:14 ` Paul Moore [this message]
2024-09-06 15:19 ` Masahiro Yamada
2024-09-06 15:37 ` Paul Moore
2024-09-06 16:06 ` Masahiro Yamada
2024-09-06 16:22 ` Paul Moore
2024-09-06 16:37 ` Masahiro Yamada
2024-09-06 17:33 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3447459d08dd7ebb58972129cddf1c44@paul-moore.com \
--to=paul@paul-moore.com \
--cc=da.gomez@samsung.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=omosnace@redhat.com \
--cc=selinux@vger.kernel.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).