From: James Morris <jmorris@namei.org>
To: Fan Wu <wufan@linux.microsoft.com>
Cc: Casey Schaufler <casey@schaufler-ca.com>,
linux-security-module@vger.kernel.org
Subject: Re: Question about inode security blob
Date: Tue, 12 Jan 2021 15:38:18 +1100 (AEDT) [thread overview]
Message-ID: <391d332-4a31-2ed8-85a3-106f393dd1db@namei.org> (raw)
In-Reply-To: <f85cdd1b-1118-026b-c696-18863ad6352e@linux.microsoft.com>
On Mon, 11 Jan 2021, Fan Wu wrote:
> > The inode->i_security should never be NULL if the inode has been
> > initialized. Any LSM hook that finds this to be NULL has probably
> > identified a bug elsewhere in the system.
> >
>
> Thanks for the quick reply. If I understand correctly, I should follow the
> first pattern if I want to use the inode blob.
I don't think it's necessary, and if there's a race somewhere causing
this, we shouldn't just paper it over.
Btw, none of the existing cases are even using WARN_ON or similar to let
the user know there's a problem.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2021-01-12 4:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 0:56 Question about inode security blob Fan Wu
2021-01-12 1:28 ` Casey Schaufler
2021-01-12 2:11 ` Fan Wu
2021-01-12 4:38 ` James Morris [this message]
2021-01-12 8:10 ` KP Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=391d332-4a31-2ed8-85a3-106f393dd1db@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=linux-security-module@vger.kernel.org \
--cc=wufan@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox