From: Mimi Zohar <zohar@linux.ibm.com>
To: Eric Snowberg <eric.snowberg@oracle.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>, Coiby Xu <coxu@redhat.com>,
David Howells <dhowells@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"davem@davemloft.net" <davem@davemloft.net>,
"dmitry.kasatkin@gmail.com" <dmitry.kasatkin@gmail.com>,
"paul@paul-moore.com" <paul@paul-moore.com>,
"jmorris@namei.org" <jmorris@namei.org>,
"serge@hallyn.com" <serge@hallyn.com>,
"pvorel@suse.cz" <pvorel@suse.cz>,
"noodles@fb.com" <noodles@fb.com>,
"tiwai@suse.de" <tiwai@suse.de>,
Kanth Ghatraju <kanth.ghatraju@oracle.com>,
Konrad Wilk <konrad.wilk@oracle.com>,
Elaine Palmer <erpalmer@linux.vnet.ibm.com>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v3 00/10] Add CA enforcement keyring restrictions
Date: Fri, 23 Dec 2022 14:45:02 -0500 [thread overview]
Message-ID: <3d959e693630e7f45a60df2c63be7815cb8136ad.camel@linux.ibm.com> (raw)
In-Reply-To: <61C653C2-A972-40DB-9738-B418A1C601FC@oracle.com>
On Fri, 2022-12-23 at 18:17 +0000, Eric Snowberg wrote:
> >> Fair enough. If this will be viewed as justification for adding the additional
> >> code, I can work on adding it. Above you mentioned a warning would be needed
> >> at a minimum and a restriction could be placed behind a Kconfig. How about for
> >> the default case I add the warning and when compiling with
> >> INTEGRITY_CA_MACHINE_KEYRING the restriction will be enforced.
> >
> > Sounds good to me. To avoid misunderstandings, will there be a Kconfig
> > menu with 3 options?
>
> I will add the three options in the next round.
>
> > There were a couple of other comments having to
> > do with variable names. Will you address them as well?
>
> And take care of the variable name changes. I won’t get back to this until January.
Enjoy your vacation and the holidays. Looking forward to the next
version.
--
thanks,
Mimi
prev parent reply other threads:[~2022-12-23 19:45 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 0:33 [PATCH v3 00/10] Add CA enforcement keyring restrictions Eric Snowberg
2022-12-14 0:33 ` [PATCH v3 01/10] KEYS: Create static version of public_key_verify_signature Eric Snowberg
2023-01-04 11:31 ` Jarkko Sakkinen
2022-12-14 0:33 ` [PATCH v3 02/10] KEYS: Add missing function documentation Eric Snowberg
2023-01-04 11:33 ` Jarkko Sakkinen
2022-12-14 0:33 ` [PATCH v3 03/10] KEYS: X.509: Parse Basic Constraints for CA Eric Snowberg
2022-12-15 11:10 ` Mimi Zohar
2023-01-04 12:29 ` Jarkko Sakkinen
2023-01-04 20:14 ` Eric Snowberg
2023-01-04 22:38 ` Mimi Zohar
2023-01-04 11:40 ` Jarkko Sakkinen
2022-12-14 0:33 ` [PATCH v3 04/10] KEYS: X.509: Parse Key Usage Eric Snowberg
2022-12-15 11:25 ` Mimi Zohar
2023-01-04 11:43 ` Jarkko Sakkinen
2023-01-04 21:46 ` Eric Snowberg
2022-12-14 0:33 ` [PATCH v3 05/10] KEYS: Introduce a CA endorsed flag Eric Snowberg
2023-01-04 11:45 ` Jarkko Sakkinen
2022-12-14 0:33 ` [PATCH v3 06/10] KEYS: Introduce keyring restriction that validates ca trust Eric Snowberg
2022-12-14 0:33 ` [PATCH v3 07/10] KEYS: X.509: Flag Intermediate CA certs as endorsed Eric Snowberg
2022-12-15 10:21 ` Mimi Zohar
2022-12-14 0:33 ` [PATCH v3 08/10] integrity: Use root of trust signature restriction Eric Snowberg
2022-12-14 0:34 ` [PATCH v3 09/10] KEYS: CA link restriction Eric Snowberg
2023-01-04 11:51 ` Jarkko Sakkinen
2023-01-04 11:54 ` Jarkko Sakkinen
2022-12-14 0:34 ` [PATCH v3 10/10] integrity: restrict INTEGRITY_KEYRING_MACHINE to restrict_link_by_ca Eric Snowberg
2022-12-15 10:21 ` [PATCH v3 00/10] Add CA enforcement keyring restrictions Mimi Zohar
2022-12-15 16:26 ` Eric Snowberg
2022-12-15 19:58 ` Mimi Zohar
2022-12-15 20:28 ` Eric Snowberg
2022-12-15 21:03 ` Mimi Zohar
2022-12-15 21:45 ` Eric Snowberg
2022-12-16 14:06 ` Coiby Xu
2022-12-18 12:21 ` Mimi Zohar
2022-12-21 18:27 ` Eric Snowberg
2022-12-21 19:01 ` Mimi Zohar
2022-12-22 15:15 ` Eric Snowberg
2022-12-22 15:41 ` Mimi Zohar
2022-12-23 16:13 ` Eric Snowberg
2022-12-23 16:34 ` Mimi Zohar
2022-12-23 18:17 ` Eric Snowberg
2022-12-23 19:45 ` Mimi Zohar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d959e693630e7f45a60df2c63be7815cb8136ad.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=coxu@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=dwmw2@infradead.org \
--cc=eric.snowberg@oracle.com \
--cc=erpalmer@linux.vnet.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=kanth.ghatraju@oracle.com \
--cc=keyrings@vger.kernel.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=noodles@fb.com \
--cc=paul@paul-moore.com \
--cc=pvorel@suse.cz \
--cc=serge@hallyn.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).