From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout13.his.huawei.com (frasgout13.his.huawei.com [14.137.139.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 679011EE03D; Fri, 18 Oct 2024 14:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=14.137.139.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729263370; cv=none; b=oNQ3ia5VgxinxbfGL+r0ThXea2W2dG0djjQ1DkQqBxx+OIAneW2Lrx+BuIHjMq+En7GUEqjkwao9MRj6YNJFC17h89zl2xevpXigg35q3plOY34rmyx6uvB5agKWekjyPLyzLSxUstC92t01oPI+3qMcA6QgMfgFQi1TQyTdTl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729263370; c=relaxed/simple; bh=62QEUV1KPsfEpMy7KQ63REX0ZDBu3fVmmN2TDPHe16c=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=stLgieYXdBNgfb4GParyECj0/jZoqLe7LSLHO4vFv2tnquYbntqWEcwcptYObs5mtm6x9Quz8TOHvpa3k7MO9im5nTwhR/91i0wEVg9+SO9ibrIgOe+6Zhtgx/Ec9qUXjKEPfSwJ2ons6d88i1e5sfW/SoTNHZGT5+HYQ6jicQM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=14.137.139.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.18.186.51]) by frasgout13.his.huawei.com (SkyGuard) with ESMTP id 4XVS1N4lgNz9v7JS; Fri, 18 Oct 2024 22:35:52 +0800 (CST) Received: from mail02.huawei.com (unknown [7.182.16.27]) by mail.maildlp.com (Postfix) with ESMTP id 1954A1404DA; Fri, 18 Oct 2024 22:56:00 +0800 (CST) Received: from [127.0.0.1] (unknown [10.204.63.22]) by APP2 (Coremail) with SMTP id GxC2BwCHNsf1dhJnRHggAw--.63843S2; Fri, 18 Oct 2024 15:55:59 +0100 (CET) Message-ID: <46d8cfe7db6f381c99455159bff1c2220dff4aed.camel@huaweicloud.com> Subject: Re: [syzbot] [integrity?] [lsm?] possible deadlock in process_measurement (4) From: Roberto Sassu To: Paul Moore Cc: Shu Han , syzbot , akpm@linux-foundation.org, dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com, hughd@google.com, jmorris@namei.org, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, roberto.sassu@huawei.com, serge@hallyn.com, stephen.smalley.work@gmail.com, syzkaller-bugs@googlegroups.com, zohar@linux.ibm.com Date: Fri, 18 Oct 2024 16:55:47 +0200 In-Reply-To: <1a1d106ea8bba8abc1d3f3cd6fdd71d03edcf764.camel@huaweicloud.com> References: <66f7b10e.050a0220.46d20.0036.GAE@google.com> <05e893036fa8753e0177db99dd48eb9d2e33476a.camel@huaweicloud.com> <70f55efdba0e682907c895ea8ba537ea435bc3aa.camel@huaweicloud.com> <1a1d106ea8bba8abc1d3f3cd6fdd71d03edcf764.camel@huaweicloud.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-CM-TRANSID:GxC2BwCHNsf1dhJnRHggAw--.63843S2 X-Coremail-Antispam: 1UD129KBjvJXoWxWrWDGF1UGr43XrWxJr15twb_yoWrXFWkpF 93Wa4Ikr4DtFyUArn2yr1UW3Wjy34UGryUWr95Jr18JFyqvF1ktr17Jr1ruryUGr95C342 qr4UWryfJw1DArDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUvYb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIEc7CjxV AFwI0_Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JM4IIrI8v6xkF7I0E8cxan2IY04v7MxkF7I0En4kS 14v26r4a6rW5MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I 8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVW8ZVWr XwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x 0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_ Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8Jr0_Cr1UYxBIdaVFxhVjvjDU0xZFpf9x07 j7l19UUUUU= X-CM-SenderInfo: purev21wro2thvvxqx5xdzvxpfor3voofrz/1tbiAgAABGcRxH8K8AABsw On Wed, 2024-10-09 at 18:23 +0200, Roberto Sassu wrote: > On Mon, 2024-10-07 at 12:58 -0400, Paul Moore wrote: > > On Mon, Oct 7, 2024 at 12:49=E2=80=AFPM Roberto Sassu > > wrote: > > > On Mon, 2024-10-07 at 12:35 -0400, Paul Moore wrote: > > > > On Mon, Oct 7, 2024 at 11:31=E2=80=AFAM Roberto Sassu > > > > wrote: > > > > > On Wed, 2024-10-02 at 23:09 -0400, Paul Moore wrote: > > > > > > On Sat, Sep 28, 2024 at 2:08=E2=80=AFPM Shu Han wrote: > > > > > > >=20 > > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > > > > > WARNING: possible circular locking dependency detected > > > > > > > > 6.11.0-syzkaller-10045-g97d8894b6f4c #0 Not tainted > > > > > > > > ------------------------------------------------------ > > > > > > > > syz-executor369/5231 is trying to acquire lock: > > > > > > > > ffff888072852370 (&sb->s_type->i_mutex_key#12){+.+.}-{3:3},= at: inode_lock include/linux/fs.h:815 [inline] > > > > > > > > ffff888072852370 (&sb->s_type->i_mutex_key#12){+.+.}-{3:3},= at: process_measurement+0x439/0x1fb0 security/integrity/ima/ima_main.c:250 > > > > > > > >=20 > > > > > > > > but task is already holding lock: > > > > > > > > ffff88807ac9a798 (&mm->mmap_lock){++++}-{3:3}, at: mmap_wri= te_lock_killable include/linux/mmap_lock.h:122 [inline] > > > > > > > > ffff88807ac9a798 (&mm->mmap_lock){++++}-{3:3}, at: __do_sys= _remap_file_pages mm/mmap.c:1649 [inline] > > > > > > > > ffff88807ac9a798 (&mm->mmap_lock){++++}-{3:3}, at: __se_sys= _remap_file_pages+0x22d/0xa50 mm/mmap.c:1624 > > > > > > > >=20 > > > > > > > > which lock already depends on the new lock. > > > > > > >=20 > > > > > > > This issue (if not a false positive?) is due to the possible = `prot` > > > > > > > change caused by the processing logic for READ_IMPLIES_EXEC i= n do_mmap(), > > > > > > > so the remap_file_pages() must perform LSM check before calli= ng do_mmap(), > > > > > > > this is what the previous commit want to do. > > > > > >=20 > > > > > > My apologies for the delay on this, I was traveling for a bit a= nd > > > > > > missed this issue while away. > > > > > >=20 > > > > > > Looking quickly at the report, I don't believe this is a false = positive. > > > > > >=20 > > > > > > > The LSM check is required to know what the `prot` is, but `pr= ot` must be > > > > > > > obtained after holding the `mmap_write_lock`. > > > > > > >=20 > > > > > > > If the `mmap_write_lock` is released after getting the `prot`= and before > > > > > > > the LSM call in remap_file_pages(), it may cause TOCTOU. > > > > > >=20 > > > > > > Looking at the IMA code, specifically the process_measurement() > > > > > > function which is called from the security_mmap_file() LSM hook= , I'm > > > > > > not sure why there is the inode_lock() protected region. Mimi? > > > > > > Roberto? My best guess is that locking the inode may have been > > > > > > necessary before we moved the IMA inode state into the inode's = LSM > > > > > > security blob, but I'm not certain. > > > > > >=20 > > > > > > Mimi and Roberto, can we safely remove the inode locking in > > > > > > process_measurement()? > > > > >=20 > > > > > I discussed a bit with Mimi. Her concern was the duplicate iint > > > > > structure creation during concurrent file accesses. Now that inod= e > > > > > integrity metadata have been moved to the inode security blob, we= can > > > > > take the iint->mutex out of the ima_iint_cache structure, and sto= re it > > > > > directly in the security blob. In this way, we can remove the ino= de > > > > > lock. > > > > >=20 > > > > > Will write a patch and see if it passes our tests. > > > >=20 > > > > That's great, thanks Roberto. Assuming all goes well we'll want to > > > > backport this everywhere we merged the remap_file_pages() patch. > > >=20 > > > Welcome. Probably it can go down only until the kernel where IMA and > > > EVM are LSMs. > >=20 > > Yes, we'll need to look at that once we solve this in Linus' tree. >=20 > #syz test: https://github.com/robertosassu/linux.git ima-remove-inode-loc= k-v1 #syz test: https://github.com/robertosassu/linux.git remap-file-pages-locki= ng-v1