From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0797C43461 for ; Wed, 16 Sep 2020 19:18:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 563552076B for ; Wed, 16 Sep 2020 19:18:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbgIPTRT (ORCPT ); Wed, 16 Sep 2020 15:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727263AbgIPRiI (ORCPT ); Wed, 16 Sep 2020 13:38:08 -0400 Received: from smtp-bc09.mail.infomaniak.ch (smtp-bc09.mail.infomaniak.ch [IPv6:2001:1600:3:17::bc09]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7C59C0086B4 for ; Wed, 16 Sep 2020 06:43:44 -0700 (PDT) Received: from smtp-2-0001.mail.infomaniak.ch (unknown [10.5.36.108]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4Bs1Vt66Xxzlhp2Z; Wed, 16 Sep 2020 15:42:30 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [94.23.54.103]) by smtp-2-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4Bs1Vr3lT6zlh8TV; Wed, 16 Sep 2020 15:42:28 +0200 (CEST) Subject: Re: [PATCH v20 05/12] LSM: Infrastructure management of the superblock To: Stephen Smalley Cc: Stephen Smalley , Casey Schaufler , Kees Cook , John Johansen , linux-kernel , Al Viro , Andy Lutomirski , Anton Ivanov , Arnd Bergmann , James Morris , Jann Horn , Jeff Dike , Jonathan Corbet , Michael Kerrisk , Richard Weinberger , "Serge E . Hallyn" , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, Linux FS Devel , linux-kselftest@vger.kernel.org, LSM List , X86 ML References: <20200802215903.91936-1-mic@digikod.net> <20200802215903.91936-6-mic@digikod.net> <779c290b-45f5-b86c-c573-2edb4004105d@tycho.nsa.gov> <03f522c0-414c-434b-a0d1-57c3b17fa67f@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <49fa967e-d60f-bd52-6fe3-c04fe56e20f6@digikod.net> Date: Wed, 16 Sep 2020 15:42:28 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 04/09/2020 16:06, Stephen Smalley wrote: > On Thu, Aug 13, 2020 at 2:39 PM Stephen Smalley > wrote: >> >> On Thu, Aug 13, 2020 at 10:17 AM Mickaël Salaün wrote: >>> >>> >>> On 12/08/2020 21:16, Stephen Smalley wrote: >>>> On 8/2/20 5:58 PM, Mickaël Salaün wrote: >>>>> From: Casey Schaufler >>>>> >>>>> Move management of the superblock->sb_security blob out >>>>> of the individual security modules and into the security >>>>> infrastructure. Instead of allocating the blobs from within >>>>> the modules the modules tell the infrastructure how much >>>>> space is required, and the space is allocated there. >>>>> >>>>> Signed-off-by: Casey Schaufler >>>>> Reviewed-by: Kees Cook >>>>> Reviewed-by: John Johansen >>>>> Reviewed-by: Stephen Smalley >>>>> Reviewed-by: Mickaël Salaün >>>>> Link: >>>>> https://lore.kernel.org/r/20190829232935.7099-2-casey@schaufler-ca.com >>>>> --- >>>>> >>>>> Changes since v17: >>>>> * Rebase the original LSM stacking patch from v5.3 to v5.7: I fixed some >>>>> diff conflicts caused by code moves and function renames in >>>>> selinux/include/objsec.h and selinux/hooks.c . I checked that it >>>>> builds but I didn't test the changes for SELinux nor SMACK. >>>> >>>> You shouldn't retain Signed-off-by and Reviewed-by lines from an earlier >>>> patch if you made non-trivial changes to it (even more so if you didn't >>>> test them). >>> >>> I think I made trivial changes according to the original patch. But >>> without reply from other people with Signed-off-by or Reviewed-by >>> (Casey, Kees, John), I'll remove them. I guess you don't want your >>> Reviewed-by to be kept, so I'll remove it, except if you want to review >>> this patch (or the modified part). >> >> At the very least your Reviewed-by line is wrong - yours should be >> Signed-off-by because the patch went through you and you modified it. >> I'll try to take a look as time permits but FYI you should this >> address (already updated in MAINTAINERS) going forward. > > I finally got around to reviewing your updated patch. You can drop > the old line and add: > Reviewed-by: Stephen Smalley > Thanks! I'll send a new series soon.