From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B159DC433F5 for ; Tue, 10 May 2022 03:38:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235580AbiEJDl7 (ORCPT ); Mon, 9 May 2022 23:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235709AbiEJDkh (ORCPT ); Mon, 9 May 2022 23:40:37 -0400 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2FFE2016C7; Mon, 9 May 2022 20:34:54 -0700 (PDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5917D3200976; Mon, 9 May 2022 23:34:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 09 May 2022 23:34:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1652153691; x= 1652240091; bh=Wf4+GirlHr8odLVWkz1C4aI3GGmAypu/lVakO44m7ok=; b=K d6w/Ky9g1ONou+rs8boNzVnFBHtYNFA1WbynVGD24JKcYKLWqLU6/jX/6JNP7rak PHLtOTz43QnIoy5mF8GRfgKHt+ESvwLJW13bIwbI7ikNVBPAlj4zg6JAzwUnNFPN jGn5u15qQuWJM4OPcfg2QGSuBdFKbuBk4yAelyVa6gcBpJM3twzbBseiBTAy4Dcs /kfW5db8YGVUfH/Li6584SZtEKKusdFuj0ZHDQTyXmOLcxj3w8qshaXGb9E9LdrC RCqb2sorM7VVhmpc4aSR1kGSolhW1dU3MoAm4IL5wnrVXTA63daH729Y3LfVseIo FRbmIkOl+MldRigeH5ybQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1652153691; x=1652240091; bh=Wf4+GirlHr8od LVWkz1C4aI3GGmAypu/lVakO44m7ok=; b=z4cDqglDdqc/osHgQ2M74yL21q/ld on9l+ORXm2aR824S7xOaod5uSPAVxA5Aejyxb4Sf2cvRQuzghCC/TdyWxCFeeewX /A0f22gQbVUlyu2/fEFWAGb6aXHaXu9M+uPFDkXsn4UBgFWNjYpuaeYjuQUO/hpx HR217Tpo2MtH4wzCJMYaPWK5Ku8OtXiYDmq/nW7f5UMwFYwxZ9y4X+a9kxEczDHi KqWv5mS8iuL9A6ieNtYMLCqQYR9UVkMM0mg5DMWL/ocJ11sni2H/RUXdVBJCUtD6 J7UZXsSTYbm7oLgZlQIVY39m0lyXOScdGjABK0D2Nk7rEpblfpf3/BI3w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedtgdejvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkuffhvfevffgjfhgtfggggfesthejredttderjeenucfhrhhomhepkfgrnhcu mfgvnhhtuceorhgrvhgvnhesthhhvghmrgifrdhnvghtqeenucggtffrrghtthgvrhhnpe dviefhveeifeevfedutdffkeeigedukeehvefgteeileeitdehgffggfffveejteenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrrghvvghnse hthhgvmhgrfidrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 9 May 2022 23:34:45 -0400 (EDT) Message-ID: <4a712f3618835ac9ba0db8d26630f8edf209a193.camel@themaw.net> Subject: Re: [RFC PATCH] getting misc stats/attributes via xattr API From: Ian Kent To: Vivek Goyal , Christian Brauner Cc: Amir Goldstein , Miklos Szeredi , linux-fsdevel , Dave Chinner , Theodore Ts'o , Karel Zak , Greg KH , linux-kernel , Linux API , linux-man , LSM , David Howells , Linus Torvalds , Al Viro , Christian Brauner , James Bottomley Date: Tue, 10 May 2022 11:34:39 +0800 In-Reply-To: References: <20220509124815.vb7d2xj5idhb2wq6@wittgenstein> <20220509150856.cfsxn5t2tvev2njx@wittgenstein> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-1.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On Mon, 2022-05-09 at 17:42 -0400, Vivek Goyal wrote: > On Mon, May 09, 2022 at 05:08:56PM +0200, Christian Brauner wrote: > > [..] > > Having "xattr" in the system call name is just confusing. These are > > fundamentally not "real" xattrs and we shouldn't mix semantics. > > There > > should be a clear distinction between traditional xattrs and this > > vfs > > and potentially fs information providing interface. > > > > Just thinking about what the manpage would look like. We would need > > to > > add a paragraph to xattr(7) explaining that in addition to the > > system.*, > > security.*, user.* and other namespaces we now also have a set of > > namespaces that function as ways to get information about mounts or > > other things instead of information attached to specific inodes. > > > > That's super random imho. If I were to be presented with this > > manpage > > I'd wonder if someone was too lazy to add a proper new system call > > with > > it's own semantics for this and just stuffed it into an existing > > API > > because it provided matching system call arguments. We can add a > > new > > system call. It's not that we're running out of them. > > FWIW, I also felt that using xattr API to get some sort of mount info > felt > very non-intutive. Yeah, people looking for this function simply wouldn't know to look here ... Ian