linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 RESEND] kexec_lock: Replace kexec_mutex() by kexec_lock() in two comments
@ 2023-08-07  2:52 Wenyu Liu
  2023-08-07 14:12 ` Mimi Zohar
  0 siblings, 1 reply; 2+ messages in thread
From: Wenyu Liu @ 2023-08-07  2:52 UTC (permalink / raw)
  To: ebiederm, zohar, dmitry.kasatkin, paul, jmorris, serge, kexec,
	linux-kernel, linux-security-module, linux-integrity
  Cc: akpm, vschneid, pmenzel, bhe, louhongxiang

kexec_mutex is replaced by an atomic variable
in 05c6257433b (panic, kexec: make __crash_kexec() NMI safe).

But there are still two comments that referenced kexec_mutex,
replace them by kexec_lock.

Signed-off-by: Wenyu Liu <liuwenyu7@huawei.com>
Acked-by: Baoquan He <bhe@redhat.com>
Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
v1 -> v2
 - fixed some mistakes in the submission information

 kernel/kexec_file.c                | 2 +-
 security/integrity/ima/ima_kexec.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/kexec_file.c b/kernel/kexec_file.c
index 881ba0d1714c..b5bbb2fe0668 100644
--- a/kernel/kexec_file.c
+++ b/kernel/kexec_file.c
@@ -624,7 +624,7 @@ int kexec_locate_mem_hole(struct kexec_buf *kbuf)
  * kexec_add_buffer - place a buffer in a kexec segment
  * @kbuf:	Buffer contents and memory parameters.
  *
- * This function assumes that kexec_mutex is held.
+ * This function assumes that kexec_lock is held.
  * On successful return, @kbuf->mem will have the physical address of
  * the buffer in memory.
  *
diff --git a/security/integrity/ima/ima_kexec.c b/security/integrity/ima/ima_kexec.c
index 419dc405c831..ad133fe120db 100644
--- a/security/integrity/ima/ima_kexec.c
+++ b/security/integrity/ima/ima_kexec.c
@@ -77,7 +77,7 @@ static int ima_dump_measurement_list(unsigned long *buffer_size, void **buffer,
  * Called during kexec_file_load so that IMA can add a segment to the kexec
  * image for the measurement list for the next kernel.
  *
- * This function assumes that kexec_mutex is held.
+ * This function assumes that kexec_lock is held.
  */
 void ima_add_kexec_buffer(struct kimage *image)
 {
-- 
2.33.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 RESEND] kexec_lock: Replace kexec_mutex() by kexec_lock() in two comments
  2023-08-07  2:52 [PATCH v2 RESEND] kexec_lock: Replace kexec_mutex() by kexec_lock() in two comments Wenyu Liu
@ 2023-08-07 14:12 ` Mimi Zohar
  0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2023-08-07 14:12 UTC (permalink / raw)
  To: Wenyu Liu, ebiederm, dmitry.kasatkin, paul, jmorris, serge, kexec,
	linux-kernel, linux-security-module, linux-integrity
  Cc: akpm, vschneid, pmenzel, bhe, louhongxiang

On Mon, 2023-08-07 at 10:52 +0800, Wenyu Liu wrote:
> kexec_mutex is replaced by an atomic variable
> in 05c6257433b (panic, kexec: make __crash_kexec() NMI safe).
> 
> But there are still two comments that referenced kexec_mutex,
> replace them by kexec_lock.
> 
> Signed-off-by: Wenyu Liu <liuwenyu7@huawei.com>
> Acked-by: Baoquan He <bhe@redhat.com>
> Acked-by: Paul Menzel <pmenzel@molgen.mpg.de>

Thank you. It's now queued 
https://git.kernel.org/pub/scm/linux/kernel/git/zohar/linux-integrity.git/log/?h=next-integrity
.

--
thanks,

Mimi


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-07 14:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-07  2:52 [PATCH v2 RESEND] kexec_lock: Replace kexec_mutex() by kexec_lock() in two comments Wenyu Liu
2023-08-07 14:12 ` Mimi Zohar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).