From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Jan Lübbe" <jlu@pengutronix.de>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Stefan Berger <stefanb@linux.ibm.com>,
linux-stable@vger.kernel.org
Subject: Re: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts
Date: Sun, 08 Sep 2019 00:21:46 +0300 [thread overview]
Message-ID: <5403fb1ecdee5c2443c8389ffd7b25e800340565.camel@linux.intel.com> (raw)
In-Reply-To: <b19179168421eb511856f0ec5fd328d97f06a68c.camel@pengutronix.de>
On Fri, 2019-09-06 at 14:37 +0200, Jan Lübbe wrote:
> This is due to the SPI accesses performed by tis_int_handler (which
> will sleep). Switching to devm_request_threaded_irq fixes this and
> leads to a successful IRQ probe.
Aah, right through tpm_tis_read32/write32(). This is definitely a new
regression. Thanks for reporting this! This was completely missed when
the support for other than TCG MMIO was implemented for the TIS driver.
This should have a patch of it own with your reported-by unless you
care to send bug fix for it.
> But: It seems that the IRQ is not acked correctly, as the interrupt
> line stays low. I suspect this is because the tpm_chip_stop from
> http://git.infradead.org/users/jjs/linux-tpmdd.git/commitdiff/9b558deab2c5d7dc23d5f7a4064892ede482ad32
> happens before the threaded handler runs. I'm currently unable to
> verify that though, as my build machine's disk just died. :/
I cannot recall all the nyances related to interrupt probing but with a
quick look I wonder why it does not utilize int_queue. Then
tpm_chip_stop() could be done synchronously.
> Regards,
> Jan
/Jarkko
prev parent reply other threads:[~2019-09-07 21:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 0:09 [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts Stefan Berger
2019-09-06 12:37 ` Jan Lübbe
2019-09-07 21:21 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5403fb1ecdee5c2443c8389ffd7b25e800340565.camel@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jlu@pengutronix.de \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-stable@vger.kernel.org \
--cc=stefanb@linux.ibm.com \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).