From: Mimi Zohar <zohar@linux.ibm.com>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>,
dmitry.kasatkin@gmail.com, eric.snowberg@oracle.com,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, devnull+dima.arista.com@kernel.org,
Roberto Sassu <roberto.sassu@huawei.com>
Subject: Re: [PATCH] ima: Add digest_size field to ima_algo_desc structure and use to show meas.
Date: Wed, 25 Feb 2026 13:37:14 -0500 [thread overview]
Message-ID: <55905382b88f00de0d7a82aff0605b6d0d9a1e8c.camel@linux.ibm.com> (raw)
In-Reply-To: <20260225125301.87996-1-roberto.sassu@huaweicloud.com>
On Wed, 2026-02-25 at 13:53 +0100, Roberto Sassu wrote:
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> Add the digest_size field to the ima_algo_desc structure to determine the
> digest size from the correct source.
>
> If the hash algorithm is among allocated PCR banks, take the value from the
> TPM bank info; if the hash algorithm is SHA1, use the predefined value; if
> the hash algorithm is the default one but not among the PCR banks, take the
> digest size from the crypto subsystem (the default hash algorithm is
> checked when parsing the ima_hash= command line option).
>
> Finally, use the new information to correctly show the template digest in
> ima_measurements_show() and ima_ascii_measurements_show().
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Thanks, Roberto. The patch looks fine, other than the patch title. Could it be
renamed as "ima: define and use a digest_size field in the ima_algo_desc
structure"?
thanks,
Mimi
next prev parent reply other threads:[~2026-02-25 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 12:53 [PATCH] ima: Add digest_size field to ima_algo_desc structure and use to show meas Roberto Sassu
2026-02-25 18:37 ` Mimi Zohar [this message]
2026-02-25 19:47 ` Mimi Zohar
2026-02-26 9:00 ` Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55905382b88f00de0d7a82aff0605b6d0d9a1e8c.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=devnull+dima.arista.com@kernel.org \
--cc=dmitry.kasatkin@gmail.com \
--cc=eric.snowberg@oracle.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
--cc=roberto.sassu@huaweicloud.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox