From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE53C282C4 for ; Mon, 4 Feb 2019 13:50:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18F1D2081B for ; Mon, 4 Feb 2019 13:50:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731416AbfBDNuA (ORCPT ); Mon, 4 Feb 2019 08:50:00 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:32864 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729207AbfBDNuA (ORCPT ); Mon, 4 Feb 2019 08:50:00 -0500 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id 4B2BB79EFBB4FE727496; Mon, 4 Feb 2019 13:49:58 +0000 (GMT) Received: from [10.204.65.155] (10.204.65.155) by smtpsuk.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 4 Feb 2019 13:49:55 +0000 Subject: Re: [PATCH v2] tpm/st33zp24: Fix the name collisions in tpm_st33zp24_spi and tpm_i2c_infineon To: Jarkko Sakkinen , CC: , , , References: <20190204133749.14176-1-jarkko.sakkinen@linux.intel.com> From: Roberto Sassu Message-ID: <575f4693-129c-469c-e54e-dbb9ad2a66f2@huawei.com> Date: Mon, 4 Feb 2019 14:49:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190204133749.14176-1-jarkko.sakkinen@linux.intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.204.65.155] X-CFilter-Loop: Reflected Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 2/4/2019 2:37 PM, Jarkko Sakkinen wrote: > Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to > ST33ZP24_BUFSIZE. > > Rename TPM_BUFSIZE defined in drivers/char/tpm/tpm_i2c_infineon.c to > TPM_I2C_INFINEON_BUFSIZE. Please also add a prefix to TPM_RETRY in tpm_i2c_nuvoton.c. Thanks Roberto > Cc: stable@vger.kernel.org > Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)") > Fixes: aad628c1d91a ("char/tpm: Add new driver for Infineon I2C TIS TPM") > Signed-off-by: Jarkko Sakkinen > --- > v2: Fix also the name collision in tpm_ic2_infineon. > drivers/char/tpm/st33zp24/i2c.c | 2 +- > drivers/char/tpm/st33zp24/spi.c | 2 +- > drivers/char/tpm/st33zp24/st33zp24.h | 4 ++-- > drivers/char/tpm/tpm_i2c_infineon.c | 15 ++++++++------- > 4 files changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c > index be5d1abd3e8e..8390c5b54c3b 100644 > --- a/drivers/char/tpm/st33zp24/i2c.c > +++ b/drivers/char/tpm/st33zp24/i2c.c > @@ -33,7 +33,7 @@ > > struct st33zp24_i2c_phy { > struct i2c_client *client; > - u8 buf[TPM_BUFSIZE + 1]; > + u8 buf[ST33ZP24_BUFSIZE + 1]; > int io_lpcpd; > }; > > diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c > index d7909ab287a8..ff019a1e3c68 100644 > --- a/drivers/char/tpm/st33zp24/spi.c > +++ b/drivers/char/tpm/st33zp24/spi.c > @@ -63,7 +63,7 @@ > * some latency byte before the answer is available (max 15). > * We have 2048 + 1024 + 15. > */ > -#define ST33ZP24_SPI_BUFFER_SIZE (TPM_BUFSIZE + (TPM_BUFSIZE / 2) +\ > +#define ST33ZP24_SPI_BUFFER_SIZE (ST33ZP24_BUFSIZE + (ST33ZP24_BUFSIZE / 2) +\ > MAX_SPI_LATENCY) > > > diff --git a/drivers/char/tpm/st33zp24/st33zp24.h b/drivers/char/tpm/st33zp24/st33zp24.h > index 6f4a4198af6a..20da0a84988d 100644 > --- a/drivers/char/tpm/st33zp24/st33zp24.h > +++ b/drivers/char/tpm/st33zp24/st33zp24.h > @@ -18,8 +18,8 @@ > #ifndef __LOCAL_ST33ZP24_H__ > #define __LOCAL_ST33ZP24_H__ > > -#define TPM_WRITE_DIRECTION 0x80 > -#define TPM_BUFSIZE 2048 > +#define TPM_WRITE_DIRECTION 0x80 > +#define ST33ZP24_BUFSIZE 2048 > > struct st33zp24_dev { > struct tpm_chip *chip; > diff --git a/drivers/char/tpm/tpm_i2c_infineon.c b/drivers/char/tpm/tpm_i2c_infineon.c > index 9086edc9066b..b9d5a1dda8d2 100644 > --- a/drivers/char/tpm/tpm_i2c_infineon.c > +++ b/drivers/char/tpm/tpm_i2c_infineon.c > @@ -26,8 +26,7 @@ > #include > #include "tpm.h" > > -/* max. buffer size supported by our TPM */ > -#define TPM_BUFSIZE 1260 > +#define TPM_I2C_INFINEON_MAX_BUFSIZE 1260 > > /* max. number of iterations after I2C NAK */ > #define MAX_COUNT 3 > @@ -63,11 +62,13 @@ enum i2c_chip_type { > UNKNOWN, > }; > > -/* Structure to store I2C TPM specific stuff */ > struct tpm_inf_dev { > struct i2c_client *client; > int locality; > - u8 buf[TPM_BUFSIZE + sizeof(u8)]; /* max. buffer size + addr */ > + /* In addition to the data itself, the buffer must fit the 7-bit I2C > + * address and the direction bit. > + */ > + u8 buf[TPM_I2C_INFINEON_MAX_BUFSIZE + 1]; > struct tpm_chip *chip; > enum i2c_chip_type chip_type; > unsigned int adapterlimit; > @@ -219,7 +220,7 @@ static int iic_tpm_write_generic(u8 addr, u8 *buffer, size_t len, > .buf = tpm_dev.buf > }; > > - if (len > TPM_BUFSIZE) > + if (len > TPM_I2C_INFINEON_MAX_BUFSIZE) > return -EINVAL; > > if (!tpm_dev.client->adapter->algo->master_xfer) > @@ -527,8 +528,8 @@ static int tpm_tis_i2c_send(struct tpm_chip *chip, u8 *buf, size_t len) > u8 retries = 0; > u8 sts = TPM_STS_GO; > > - if (len > TPM_BUFSIZE) > - return -E2BIG; /* command is too long for our tpm, sorry */ > + if (len > TPM_I2C_INFINEON_BUFSIZE) > + return -E2BIG; > > if (request_locality(chip, 0) < 0) > return -EBUSY; > -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Bo PENG, Jian LI, Yanli SHI