linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Paul Moore <paul@paul-moore.com>
Cc: linux-audit@redhat.com, audit@vger.kernel.org,
	linux-security-module <linux-security-module@vger.kernel.org>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] audit: add task history record
Date: Thu, 24 Aug 2023 11:55:31 -0400	[thread overview]
Message-ID: <5966626.lOV4Wx5bFT@x2> (raw)
In-Reply-To: <CAHC9VhTZE2BinivPRLJ9S_21YcmXA6tMdDtAm5w3nk0dbZ0j1w@mail.gmail.com>

Hello Paul,

On Thursday, August 24, 2023 9:30:10 AM EDT Paul Moore wrote:
> On Thu, Aug 24, 2023 at 9:21 AM Tetsuo Handa
> <penguin-kernel@i-love.sakura.ne.jp> wrote:
> > On 2023/08/23 23:48, Paul Moore wrote:
> > > We've already discussed this both from a kernel load perspective (it
> > > should be able to handle the load, if not that is a separate problem
> > > to address) as well as the human perspective (if you want auditing,
> > > you need to be able to handle auditing).
> > 
> > No. You haven't shown us audit rules that can satisfy requirements shown
> > below.> 
> >   (1) Catch _all_ process creations (both via fork()/clone() system calls
> >   and kthread_create() from the kernel), and duplicate the history upon
> >   process creation.
> 
> Create an audit filter rule to record the syscalls you are interested
> in logging.
> 
> >   (2) Catch _all_ execve(), and update the history upon successful
> >   execve().
> 
> Create an audit filter rule to record the syscalls you are interested
> in logging.
> 
> >   (3) Catch _all_ process terminations (both exit()/exit_group()/kill()
> >   system  calls and internal reasons such as OOM killer), and erase the
> >   history upon process termination.
> 
> Create an audit filter rule to record the events you are interested in
> logging, if there is an event which isn't being recorded feel free to
> submit a patch to generate an audit record.

I'm not for or against this or a similar patch. The information Tetsuo is 
looking for cannot be recreated from logs. What if it were a daemon that's 
been running for a year? With the amount of data you are suggesting to log, 
it would have rotated away months ago. To log all of the system calls you 
mention would be abusive of the audit system, hurt performance, wear out SSD 
drives, and ultimately fail.

There may be other reasons you don't like the patch and that's fine. But 
saying it can be done from user space after the fact is not helpful.

-Steve



  parent reply	other threads:[~2023-08-24 15:57 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-11 10:58 [PATCH] audit: add task history record Tetsuo Handa
2023-08-11 17:50 ` Richard Guy Briggs
2023-08-12 10:08   ` Tetsuo Handa
2023-08-15 18:44 ` Paul Moore
2023-08-16 10:10   ` Tetsuo Handa
2023-08-16 13:53     ` Paul Moore
2023-08-18 10:29       ` Tetsuo Handa
2023-08-18 14:59         ` Paul Moore
2023-08-19  7:09           ` Tetsuo Handa
2023-08-21 16:04             ` Serge E. Hallyn
2023-08-21 22:23               ` Tetsuo Handa
2023-08-21 16:35             ` Paul Moore
2023-08-23 14:18               ` Tetsuo Handa
2023-08-23 14:48                 ` Paul Moore
2023-08-24 13:21                   ` Tetsuo Handa
2023-08-24 13:30                     ` Paul Moore
2023-08-24 13:39                       ` Tetsuo Handa
2023-08-24 13:47                         ` Tetsuo Handa
2023-08-24 14:26                           ` Paul Moore
2023-08-24 22:24                             ` Tetsuo Handa
2023-08-25  3:36                               ` Paul Moore
2023-08-26  6:38                                 ` Tetsuo Handa
2023-08-26 14:47                                   ` Paul Moore
2023-08-24 14:24                         ` Paul Moore
2023-08-24 15:55                       ` Steve Grubb [this message]
2023-08-24 17:02                         ` Paul Moore
2023-08-22 16:29       ` Steve Grubb
2023-08-22 17:58         ` Paul Moore
2023-08-21 17:29 ` Serge Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5966626.lOV4Wx5bFT@x2 \
    --to=sgrubb@redhat.com \
    --cc=audit@vger.kernel.org \
    --cc=casey@schaufler-ca.com \
    --cc=linux-audit@redhat.com \
    --cc=linux-security-module@vger.kernel.org \
    --cc=paul@paul-moore.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).