From: Mimi Zohar <zohar@linux.ibm.com>
To: xiujianfeng <xiujianfeng@huawei.com>,
Ahmad Fatoum <a.fatoum@pengutronix.de>,
dmitry.kasatkin@gmail.com, jmorris@namei.org, serge@hallyn.com
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] evm: Use IS_ENABLED to initialize .enabled
Date: Tue, 21 Jun 2022 10:03:39 -0400 [thread overview]
Message-ID: <5d0c291bb4a674a6733a18f9eb67cf40193732f4.camel@linux.ibm.com> (raw)
In-Reply-To: <812c4ee9-56f7-900a-df48-f3ca3e15542f@huawei.com>
On Tue, 2022-06-21 at 18:58 +0800, xiujianfeng wrote:
> Hi, Ahmad
>
> 在 2022/6/7 14:06, Ahmad Fatoum 写道:
> > On 06.06.22 12:10, Xiu Jianfeng wrote:
> >> Use IS_ENABLED(CONFIG_XXX) instead of #ifdef/#endif statements to
> >> initialize .enabled, minor simplicity improvement.
The difference between using ifdef's and IS_ENABLED is when the
decision is made - build time, run time. Please update the patch
description providing an explanation for needing to make the decision
at run time.
thanks,
Mimi
next prev parent reply other threads:[~2022-06-21 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-06 10:10 [PATCH -next] evm: Use IS_ENABLED to initialize .enabled Xiu Jianfeng
2022-06-07 6:06 ` Ahmad Fatoum
2022-06-21 10:58 ` xiujianfeng
2022-06-21 14:03 ` Mimi Zohar [this message]
2022-06-22 2:17 ` Eric Biggers
2022-06-26 16:13 ` Mimi Zohar
2022-06-29 3:59 ` xiujianfeng
2022-07-07 23:15 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d0c291bb4a674a6733a18f9eb67cf40193732f4.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=a.fatoum@pengutronix.de \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=xiujianfeng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).