From: why2jjj.linux@gmail.com (J Freyensee)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 3/5] tpm: migrate tpm2_probe() to use struct tpm_buf
Date: Thu, 1 Mar 2018 14:10:17 -0800 [thread overview]
Message-ID: <5d8921fb-f7e0-5498-99e2-d4d84aa597f3@gmail.com> (raw)
In-Reply-To: <20180228195819.22231-4-jarkko.sakkinen@linux.intel.com>
.
.
.
I'm new to this area of the kernel, but I'm not getting these lines:
> + rc = tpm_transmit_cmd(chip, NULL, buf.data, PAGE_SIZE, 0, 0, NULL);
> + tpm_buf_destroy(&buf);
> if (rc < 0)
Why is this if() check not directly after the tpm_transmit_cmd() call
that sets rc?? Is it correct you want to destroy buf regardless of the
tpm_transmit_cmd() outcome?
> return rc;
> -
> - if (be16_to_cpu(cmd.header.out.tag) == TPM2_ST_NO_SESSIONS)
> + out = (struct tpm_output_header *)buf.data;
So buf has been destroyed, buf.data sill has something valid to assign
to out?
> + if (be16_to_cpu(out->tag) == TPM2_ST_NO_SESSIONS)
> chip->flags |= TPM_CHIP_FLAG_TPM2;
>
> return 0;
Thanks,
Jay
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-01 22:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 19:58 [PATCH 0/5] Migrate all TPM 2.0 commands to use struct tpm_buf Jarkko Sakkinen
2018-02-28 19:58 ` [PATCH 1/5] tpm: Trigger only missing TPM 2.0 self tests Jarkko Sakkinen
2018-03-03 20:11 ` James Bottomley
2018-03-05 11:23 ` Jarkko Sakkinen
2018-02-28 19:58 ` [PATCH 2/5] tpm: migrate tpm2_shutdown() to use struct tpm_buf Jarkko Sakkinen
2018-02-28 20:25 ` Jason Gunthorpe
2018-03-01 10:11 ` Jarkko Sakkinen
2018-02-28 19:58 ` [PATCH 3/5] tpm: migrate tpm2_probe() " Jarkko Sakkinen
2018-03-01 22:10 ` J Freyensee [this message]
2018-03-05 11:11 ` Jarkko Sakkinen
2018-02-28 19:58 ` [PATCH 4/5] tpm: migrate tpm2_get_tpm_pt() " Jarkko Sakkinen
2018-02-28 19:58 ` [PATCH 5/5] tpm: migrate tpm2_get_random() " Jarkko Sakkinen
2018-03-01 10:21 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d8921fb-f7e0-5498-99e2-d4d84aa597f3@gmail.com \
--to=why2jjj.linux@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).