From: Randy Dunlap <rdunlap@infradead.org>
To: Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, Jann Horn <jannh@google.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Cc: "Eric Dumazet" <edumazet@google.com>,
"Oleg Nesterov" <oleg@redhat.com>,
"David S. Miller" <davem@davemloft.net>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Daan De Meyer" <daan.j.demeyer@gmail.com>,
"David Rheinsberg" <david@readahead.eu>,
"Jakub Kicinski" <kuba@kernel.org>, "Jan Kara" <jack@suse.cz>,
"Lennart Poettering" <lennart@poettering.net>,
"Luca Boccassi" <luca.boccassi@gmail.com>,
"Mike Yuan" <me@yhndnzj.com>, "Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Alexander Mikhalitsyn" <alexander@mihalicyn.com>
Subject: Re: [PATCH v8 4/9] coredump: add coredump socket
Date: Thu, 22 May 2025 17:59:39 -0700 [thread overview]
Message-ID: <5e9ccdad-a9f4-4c8f-85b0-430edd910590@infradead.org> (raw)
In-Reply-To: <20250516-work-coredump-socket-v8-4-664f3caf2516@kernel.org>
Hi,
On 5/16/25 4:25 AM, Christian Brauner wrote:
> Coredumping currently supports two modes:
>
> ---
> fs/coredump.c | 118 ++++++++++++++++++++++++++++++++++++++++++++++++++--
> include/linux/net.h | 1 +
> net/unix/af_unix.c | 54 ++++++++++++++++++------
> 3 files changed, 156 insertions(+), 17 deletions(-)
>
[snip]
git a/include/linux/net.h b/include/linux/net.h> index 0ff950eecc6b..139c85d0f2ea 100644
> --- a/include/linux/net.h
> +++ b/include/linux/net.h
> @@ -81,6 +81,7 @@ enum sock_type {
> #ifndef SOCK_NONBLOCK
> #define SOCK_NONBLOCK O_NONBLOCK
> #endif
> +#define SOCK_COREDUMP O_NOCTTY
>
> #endif /* ARCH_HAS_SOCKET_TYPES */
MIPS sets ARCH_HAS_SOCKET_TYPES so the new define above is not used,
causing:
net/unix/af_unix.c:1152:21: error: 'SOCK_COREDUMP' undeclared (f
irst use in this function); did you mean 'SOCK_RDM'?
--
~Randy
next prev parent reply other threads:[~2025-05-23 1:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 11:25 [PATCH v8 0/9] coredump: add coredump socket Christian Brauner
2025-05-16 11:25 ` [PATCH v8 1/9] coredump: massage format_corename() Christian Brauner
2025-05-16 11:25 ` [PATCH v8 2/9] coredump: massage do_coredump() Christian Brauner
2025-05-16 11:25 ` [PATCH v8 3/9] coredump: reflow dump helpers a little Christian Brauner
2025-05-16 11:25 ` [PATCH v8 4/9] coredump: add coredump socket Christian Brauner
2025-05-16 14:33 ` Jann Horn
2025-05-22 23:25 ` Paul Moore
2025-05-23 0:59 ` Randy Dunlap [this message]
2025-05-16 11:25 ` [PATCH v8 5/9] pidfs, coredump: add PIDFD_INFO_COREDUMP Christian Brauner
2025-05-16 14:37 ` Jann Horn
2025-05-16 11:25 ` [PATCH v8 6/9] coredump: show supported coredump modes Christian Brauner
2025-05-16 11:25 ` [PATCH v8 7/9] coredump: validate socket name as it is written Christian Brauner
2025-05-16 11:25 ` [PATCH v8 8/9] selftests/pidfd: add PIDFD_INFO_COREDUMP infrastructure Christian Brauner
2025-05-16 11:25 ` [PATCH v8 9/9] selftests/coredump: add tests for AF_UNIX coredumps Christian Brauner
2025-05-20 19:28 ` [PATCH v8 0/9] coredump: add coredump socket Stephen Hemminger
2025-05-21 0:41 ` Kuniyuki Iwashima
2025-05-21 0:54 ` Jann Horn
2025-05-21 15:12 ` Christian Brauner
2025-05-21 11:12 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e9ccdad-a9f4-4c8f-85b0-430edd910590@infradead.org \
--to=rdunlap@infradead.org \
--cc=alexander@mihalicyn.com \
--cc=brauner@kernel.org \
--cc=daan.j.demeyer@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=david@readahead.eu \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jack@suse.cz \
--cc=jannh@google.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=lennart@poettering.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=luca.boccassi@gmail.com \
--cc=me@yhndnzj.com \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=pabeni@redhat.com \
--cc=tsbogend@alpha.franken.de \
--cc=viro@zeniv.linux.org.uk \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).