From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55A98C0015E for ; Fri, 28 Jul 2023 16:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229823AbjG1QOU (ORCPT ); Fri, 28 Jul 2023 12:14:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbjG1QOS (ORCPT ); Fri, 28 Jul 2023 12:14:18 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB1C82D42 for ; Fri, 28 Jul 2023 09:13:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690560814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1Dyh7+qatvQDKM5qDRHq8YkO5TCQeLww3uN1vYmzEUU=; b=JDkY0x11DPue2B7zgbfvSTctHF2nLb0vlVBbmrzahlW4PPQyOD18U+2YNhtq6XCY3cpDox +6hckE6pu3MDwQicFHao3ndEeD7uJvlr/XM9YToF9mW4G0CdE5PP80OYUj2nm15r/mXEvd VcZYhlvCMURE3r44tYduQe4spk5w0Z4= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-iN-zgzZzPk623aO4vgYudw-1; Fri, 28 Jul 2023 12:13:30 -0400 X-MC-Unique: iN-zgzZzPk623aO4vgYudw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-99bd6ea0d9eso131539966b.3 for ; Fri, 28 Jul 2023 09:13:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690560809; x=1691165609; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1Dyh7+qatvQDKM5qDRHq8YkO5TCQeLww3uN1vYmzEUU=; b=OQETGKp6bpmWpyhIS4o4YY10IYdz/rbsX0C3AOEbi5fX0qDBLxIKRTepEChAQMn123 Cnf+xQvPCNKO2vRH26ntNC8yooq2DGv+LaVODCVMkm/RiAE/En12lRFzJ3Ip/FxX0bj3 +yaEGgEd4ibhxBvnygJuS4qzDDLPLHppYbeIyofzibLWxBfvPHhEQhFAFLAS7Eh/kjU1 7z0ZOm7dPbAiF3KcFb767R0JBoEOLIrDbL6e2zO//tEUEdRiFoJ3Bi9UhnvqjZt4z6KZ BU9BKzEsjpAP8H8btSeIAtecNZJydEzD5pxPBpXnIdHxZRz07smRLM1hogKPdstyv5wI rHYA== X-Gm-Message-State: ABy/qLaFR2PIuMDG9K0SEvZBCxZBpyM+GylqaAmE/f8W/sKBsaYG5VOw OQttyutuY6vdS97sZp1YGUtIAwCsDZX4V+pYfPehrNgaVeI88U9RvRf9Fh/nBzlW5YYT4RHU3MX owrYRRdYWtyHyHDGGaZ7kaatD0Qjb/ttt1Ran X-Received: by 2002:a17:906:5354:b0:99b:efd3:3dcc with SMTP id j20-20020a170906535400b0099befd33dccmr1357342ejo.62.1690560809626; Fri, 28 Jul 2023 09:13:29 -0700 (PDT) X-Google-Smtp-Source: APBJJlHd2sX/AyGtIAscRR2p4pTksaGOsuCTBRQ37WpaEGChaEB1fcJtjozFJjrwhV4jFSHGD+pttg== X-Received: by 2002:a17:906:5354:b0:99b:efd3:3dcc with SMTP id j20-20020a170906535400b0099befd33dccmr1357325ejo.62.1690560809219; Fri, 28 Jul 2023 09:13:29 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:9af8:e5f5:7516:fa89? ([2001:b07:6468:f312:9af8:e5f5:7516:fa89]) by smtp.googlemail.com with ESMTPSA id gy26-20020a170906f25a00b00993470682e5sm2197928ejb.32.2023.07.28.09.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jul 2023 09:13:28 -0700 (PDT) Message-ID: <6da710cf-2bc0-bb6e-26f1-fba14ca767db@redhat.com> Date: Fri, 28 Jul 2023 18:13:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [RFC PATCH v11 10/29] mm: Add AS_UNMOVABLE to mark mapping as completely unmovable To: Vlastimil Babka , Matthew Wilcox , "Kirill A . Shutemov" Cc: Sean Christopherson , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-11-seanjc@google.com> <20230725102403.xywjqlhyqkrzjok6@box.shutemov.name> <692b09f7-70d9-1119-7fe2-3e7396ec259d@suse.cz> From: Paolo Bonzini In-Reply-To: <692b09f7-70d9-1119-7fe2-3e7396ec259d@suse.cz> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: On 7/28/23 18:02, Vlastimil Babka wrote: >> There's even a comment to that effect later on in the function: > Hmm, well spotted. But it wouldn't be so great if we now had to lock every > inspected page (and not just dirty pages), just to check the AS_ bit. > > But I wonder if this is leftover from previous versions. Are the guest pages > even PageLRU currently? (and should they be, given how they can't be swapped > out or anything?) If not, isolate_migratepages_block will skip them anyway. No, they're not (migration or even swap-out is not excluded for the future, but for now it's left for future work. Paolo