From: R Nageswara Sastry <rnsastry@linux.ibm.com>
To: Srish Srinivasan <ssrish@linux.ibm.com>,
linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com,
christophe.leroy@csgroup.eu,
James.Bottomley@HansenPartnership.com, jarkko@kernel.org,
zohar@linux.ibm.com, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, nayna@linux.ibm.com
Subject: Re: [PATCH v2 01/10] pseries/plpks: update PKS documentation and maintainer entry
Date: Fri, 4 Sep 2026 11:40:01 +0530 [thread overview]
Message-ID: <6fed0a01-964e-4945-b598-a890cbcb6da5@linux.ibm.com> (raw)
In-Reply-To: <20260831111738.334857-2-ssrish@linux.ibm.com>
On 31.08.2026 4:47 PM, Srish Srinivasan wrote:
> Wrap long PKS hcall return-value lines consistently and fix a typo in the
> H_PKS_UNWRAP_OBJECT description.
>
> Also update the MAINTAINERS entry from KEYS-TRUSTED-PLPKS to
> KEYS-TRUSTED-PKWM to reflect the PowerVM Key Wrapping Module naming.
>
> Signed-off-by: Srish Srinivasan <ssrish@linux.ibm.com>
Tested-by: R Nageswara Sastry <rnsastry@linux.ibm.com>
Documentation-only change. Gone through documentation.
Used this data in test cases creation.
> ---
> Documentation/arch/powerpc/papr_hcalls.rst | 16 ++++++++--------
> MAINTAINERS | 2 +-
> 2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/arch/powerpc/papr_hcalls.rst b/Documentation/arch/powerpc/papr_hcalls.rst
> index 14e39f095a1c..44c9c8b32ae3 100644
> --- a/Documentation/arch/powerpc/papr_hcalls.rst
> +++ b/Documentation/arch/powerpc/papr_hcalls.rst
> @@ -305,8 +305,8 @@ like core instruction, core LLAT and nest.
> | Input: authorization, objectlabel, objectlabellen, policy, out, outlen
> | Out: *Hypervisor Generated Key, or None when the wrapping key policy is set*
> | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H_P2,
> - H_P3, H_P4, H_P5, H_P6, H_Authority, H_Nomem, H_Busy, H_Resource,
> - H_Aborted*
> + H_P3, H_P4, H_P5, H_P6, H_Authority, H_Nomem, H_Busy,
> + H_Resource, H_Aborted*
>
> H_PKS_GEN_KEY is used to have the hypervisor generate a new random key.
> This key is stored as an object in the Power LPAR Platform KeyStore with
> @@ -321,8 +321,8 @@ the user. Generation of wrapping keys is supported only for a key size of
> | inlen, out, outlen, continue-token
> | Out: *continue-token, byte size of wrapped object, wrapped object*
> | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H_P2,
> - H_P3, H_P4, H_P5, H_P6, H_P7, H_P8, H_P9, H_Authority, H_Invalid_Key,
> - H_NOT_FOUND, H_Busy, H_LongBusy, H_Aborted*
> + H_P3, H_P4, H_P5, H_P6, H_P7, H_P8, H_P9, H_Authority,
> + H_Invalid_Key, H_NOT_FOUND, H_Busy, H_LongBusy, H_Aborted*
>
> H_PKS_WRAP_OBJECT is used to wrap an object using a wrapping key stored in the
> Power LPAR Platform KeyStore and return the wrapped object to the caller. The
> @@ -331,16 +331,16 @@ which must have been previously created with H_PKS_GEN_KEY. The provided object
> is then encrypted with the wrapping key and additional metadata and the result
> is returned to the caller.
>
> -
> **H_PKS_UNWRAP_OBJECT**
>
> | Input: authorization, objectwrapflags, in, inlen, out, outlen, continue-token
> | Out: *continue-token, byte size of unwrapped object, unwrapped object*
> | Return Value: *H_SUCCESS, H_Function, H_State, H_R_State, H_Parameter, H_P2,
> - H_P3, H_P4, H_P5, H_P6, H_P7, H_Authority, H_Unsupported, H_Bad_Data,
> - H_NOT_FOUND, H_Invalid_Key, H_Busy, H_LongBusy, H_Aborted*
> + H_P3, H_P4, H_P5, H_P6, H_P7, H_Authority, H_Unsupported,
> + H_Bad_Data, H_NOT_FOUND, H_Invalid_Key, H_Busy, H_LongBusy,
> + H_Aborted*
>
> -H_PKS_UNWRAP_OBJECT is used to unwrap an object that was previously warapped with
> +H_PKS_UNWRAP_OBJECT is used to unwrap an object that was previously wrapped with
> H_PKS_WRAP_OBJECT.
>
> References
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3a19da74d00c..6b91d7f081c4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14491,7 +14491,7 @@ S: Supported
> F: include/keys/trusted_dcp.h
> F: security/keys/trusted-keys/trusted_dcp.c
>
> -KEYS-TRUSTED-PLPKS
> +KEYS-TRUSTED-PKWM
> M: Srish Srinivasan <ssrish@linux.ibm.com>
> M: Nayna Jain <nayna@linux.ibm.com>
> L: linux-integrity@vger.kernel.org
--
Thanks and Regards
R.Nageswara Sastry
next prev parent reply other threads:[~2026-09-04 6:10 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 11:17 [PATCH v2 00/10] Extend PKWM to support user-created wrapping keys Srish Srinivasan
2026-08-31 11:17 ` [PATCH v2 01/10] pseries/plpks: update PKS documentation and maintainer entry Srish Srinivasan
2026-09-04 6:10 ` R Nageswara Sastry [this message]
2026-08-31 11:17 ` [PATCH v2 02/10] pseries/plpks: fix error handling in plpks_read_var() Srish Srinivasan
2026-09-04 6:10 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 03/10] pseries/plpks: improve type consistency and parameter validation Srish Srinivasan
2026-09-04 6:11 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 04/10] keys/trusted_keys: propagate wrapping key generation errors Srish Srinivasan
2026-09-04 6:12 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 05/10] pseries/plpks: rename the default wrapping key macro Srish Srinivasan
2026-09-04 6:13 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 06/10] pseries/plpks: fix self-reference in plpks_var initializer Srish Srinivasan
2026-09-04 6:14 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 07/10] pseries/plpks: hide wrapping_features when unsupported Srish Srinivasan
2026-09-04 6:16 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 08/10] pseries/plpks: add HCALLs for PKWM wrapping key life cycle management Srish Srinivasan
2026-09-04 6:16 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 09/10] keys/trusted_keys: enable PKWM wrapping key selection by label Srish Srinivasan
2026-09-04 6:17 ` R Nageswara Sastry
2026-08-31 11:17 ` [PATCH v2 10/10] pseries/plpks/wrapkey: expose PKWM wrapping key management to userspace via sysfs Srish Srinivasan
2026-09-04 6:19 ` R Nageswara Sastry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fed0a01-964e-4945-b598-a890cbcb6da5@linux.ibm.com \
--to=rnsastry@linux.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=christophe.leroy@csgroup.eu \
--cc=jarkko@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=nayna@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=ssrish@linux.ibm.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox