From: Roberto Sassu <roberto.sassu@huawei.com>
To: KP Singh <kpsingh@kernel.org>
Cc: "ast@kernel.org" <ast@kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
"andrii@kernel.org" <andrii@kernel.org>,
"martin.lau@linux.dev" <martin.lau@linux.dev>,
"song@kernel.org" <song@kernel.org>, "yhs@fb.com" <yhs@fb.com>,
"john.fastabend@gmail.com" <john.fastabend@gmail.com>,
"sdf@google.com" <sdf@google.com>,
"haoluo@google.com" <haoluo@google.com>,
"jolsa@kernel.org" <jolsa@kernel.org>,
"corbet@lwn.net" <corbet@lwn.net>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"jarkko@kernel.org" <jarkko@kernel.org>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"paul@paul-moore.com" <paul@paul-moore.com>,
"jmorris@namei.org" <jmorris@namei.org>,
"serge@hallyn.com" <serge@hallyn.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"keyrings@vger.kernel.org" <keyrings@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kselftest@vger.kernel.org"
<linux-kselftest@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v10 5/9] bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs
Date: Tue, 16 Aug 2022 08:40:14 +0000 [thread overview]
Message-ID: <7278db1e90de4c7bb669449e897d1946@huawei.com> (raw)
In-Reply-To: <CACYkzJ718fr2TsvX0JPhTRiMQH8=HwaxLShrETLvrhPUy2p8OQ@mail.gmail.com>
> From: KP Singh [mailto:kpsingh@kernel.org]
> Sent: Friday, August 12, 2022 2:50 AM
[...]
> > +/**
> > + * bpf_key_put - decrement key reference count if key is valid and free
> bpf_key
> > + * @bkey: bpf_key structure
> > + *
> > + * Decrement the reference count of the key inside *bkey*, if the pointer
> > + * is valid, and free *bkey*.
> > + */
>
> This is more of a style thing but your comment literally describes the
> small function
> below. Do we really need this?
Thanks for the review, KP. Just kept this, to follow the style of kernel
documentation for functions.
Roberto
next prev parent reply other threads:[~2022-08-16 9:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-10 16:59 [PATCH v10 0/9] bpf: Add kfuncs for PKCS#7 signature verification Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 1/9] bpf: Allow kfuncs to be used in LSM programs Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 2/9] btf: Handle dynamic pointer parameter in kfuncs Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 3/9] bpf: Export bpf_dynptr_get_size() Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 4/9] KEYS: Move KEY_LOOKUP_ to include/linux/key.h Roberto Sassu
2022-08-12 0:19 ` KP Singh
2022-08-10 16:59 ` [PATCH v10 5/9] bpf: Add bpf_lookup_*_key() and bpf_key_put() kfuncs Roberto Sassu
2022-08-10 21:33 ` Alexei Starovoitov
2022-08-11 7:46 ` Roberto Sassu
2022-08-11 12:02 ` Roberto Sassu
2022-08-11 23:52 ` Daniel Müller
2022-08-12 8:11 ` Roberto Sassu
2022-08-15 16:22 ` Daniel Müller
2022-08-12 0:49 ` KP Singh
2022-08-16 8:40 ` Roberto Sassu [this message]
2022-08-10 16:59 ` [PATCH v10 6/9] bpf: Add bpf_verify_pkcs7_signature() kfunc Roberto Sassu
2022-08-12 0:54 ` KP Singh
2022-08-10 16:59 ` [PATCH v10 7/9] selftests/bpf: Add verifier tests for bpf_lookup_*_key() and bpf_key_put() Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 8/9] selftests/bpf: Add additional tests for bpf_lookup_*_key() Roberto Sassu
2022-08-10 16:59 ` [PATCH v10 9/9] selftests/bpf: Add test for bpf_verify_pkcs7_signature() kfunc Roberto Sassu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7278db1e90de4c7bb669449e897d1946@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=haoluo@google.com \
--cc=jarkko@kernel.org \
--cc=jmorris@namei.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=paul@paul-moore.com \
--cc=rostedt@goodmis.org \
--cc=sdf@google.com \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).