From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31B5B210EC for ; Wed, 22 May 2024 18:40:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716403240; cv=none; b=PtApixauElakadzr2cqMawem6GiRdEaMT3loN/OmfvEOJz1S0+0IV+1jHjqN9SAeW3o96/LMkp5UMM64uBc5L8v5ec7L7htVtrOzv5JrJmQbmkAIqIz3TiMUAarRDqI1SR1WPpNFVDLJW/y2iBWfM4YCqB4pHsIcBoOA3pvp0Qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716403240; c=relaxed/simple; bh=pvfNI1321JVtef7N+59lYxiObUuoIkn6QTtflB1MBjE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jmgk/8BFp0Ry6MWTPK3F3geDfpjPq8uLNCfRC4QDpDExZRj6LJOyjaxBamgFhCw7/bZj4VEJiOvrXVTCjYCQc4S/nD91KEni6ZoQR7HgRlcEW7ylBTT68swhOyFCYcfxTBtxNty8ZQ4lSbt7CXB8a1r90dtLOj/7vu+TlooZ8oA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=ZiAfGJ8/; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="ZiAfGJ8/" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7e24bcce578so24107939f.0 for ; Wed, 22 May 2024 11:40:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1716403238; x=1717008038; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=ZiAfGJ8/7Tp3Wp5CYTquG8GZV24qMCLf0ceknIzVUcWQ/8PEFow+ystDmKwo3No7nx Gs0VPJw/OIHVC7sIc/TknKQExOnL7DRsjptWGKUDfxLt4Hpfmkob/lyeltGGr/tH1dpJ g8lwbAoUPdmzQL8TWpUmDt1wjZrxz0Fp1sbNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716403238; x=1717008038; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2CkJWPtWzq2cjcP7a09if5B9kWWmXWyc6FlwIT3mHR0=; b=hldl74XPxOiSk1+OEKrstFw9z1KBGxXtFIuELErTA1jiGO+RcQ4kX3qxz0NMD+CKw4 DbPHLoD/bo8NOyrWJlBgZSRX3nD3B/W/isYGO9YewqvskccsJDFT/QUaz+fIxN3iq8D8 wzB/WzMJx1sel8XVf9x1Wpq1T3aDT0mFtELRUVvv9x9Ttse4ZsGp5VHIWOFH2mSC/OBv hSZal0GCD3ZtBWqOAJCXTdr381JQmOkEjn2YBWL4kjuUOm6T55S32v925QObg0xAKBw2 Atqo1iyeu65FUkGqIX/FAjzSyeNIEFjOa0LePYXtwnH5BgXw4yPru09MszK7AgtkkFyz +XVg== X-Forwarded-Encrypted: i=1; AJvYcCXxJVzk4IlBVxtUfm8k4FAqAmWpWjLFFvPlFdfcQ0gw33myrljvEAqDeOLIQVKabbMkFxVIoSweDVibYV5Y/3oA/5TGX6CJRpnctt49082S8UDQC2KB X-Gm-Message-State: AOJu0YybLr/EZkKlooIHeWebrVIPooS9tdlirv0874902zH/GabFIgD5 IOhUtw4erKoK6J5pkt8MriF/JetUTf34QNINN9JzLxP+7ZrHPAJ527bTsyXUjX4= X-Google-Smtp-Source: AGHT+IHfJbSzf9eR6h+5NiCKdgJYC/D5h2NHJ2n/qeMndC5IVVrtGPtwRsxEDeIFRtYop2k9g8p2Vw== X-Received: by 2002:a05:6602:420a:b0:7de:b279:fb3e with SMTP id ca18e2360f4ac-7e37db353b9mr293535939f.1.1716403238250; Wed, 22 May 2024 11:40:38 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-48a42b0e43dsm4496318173.101.2024.05.22.11.40.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 11:40:37 -0700 (PDT) Message-ID: <7a7d6b6c-0f28-4ffe-9bf2-a25c088636db@linuxfoundation.org> Date: Wed, 22 May 2024 12:40:36 -0600 Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 00/68] Define _GNU_SOURCE for sources using To: Edward Liaw , Jakub Kicinski Cc: Andrew Morton , shuah@kernel.org, =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , =?UTF-8?Q?G=C3=BCnther_Noack?= , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jesper Dangaard Brouer , John Fastabend , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, Shuah Khan References: <20240522005913.3540131-1-edliaw@google.com> <6caf3332-9ed9-4257-9532-4fd71c465c0d@linuxfoundation.org> <20240522101349.565a745e@kernel.org> Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 5/22/24 11:44, Edward Liaw wrote: > On Wed, May 22, 2024 at 10:13 AM Jakub Kicinski wrote: >> >> On Wed, 22 May 2024 10:19:33 -0600 Shuah Khan wrote: >>> On 5/21/24 18:56, Edward Liaw wrote: >>>> Centralizes the definition of _GNU_SOURCE into KHDR_INCLUDES and removes >>>> redefinitions of _GNU_SOURCE from source code. >>>> >>>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced >>>> asprintf into kselftest_harness.h, which is a GNU extension and needs >>> >>> Easier solution to define LINE_MAX locally. In gerenal it is advisable >>> to not add local defines, but it is desirable in some cases to avoid >>> churn like this one. >> >> Will the patch that Andrew applied: >> https://lore.kernel.org/all/20240519213733.2AE81C32781@smtp.kernel.org/ >> make its way to Linus? As you say that's a much simpler fix. > Thank you Jakub. Yes. This is a simpler fix. > Right, this patch series may be unnecessary after all, since the > problem is fixed by that patch. > > It might be better to drop the series unless it is desirable to > centralize the declaration of _GNU_SOURCE to the root Makefile / > lib.mk. If that is still wanted, maybe a more palatable approach > would be to surround every instance of #define _GNU_SOURCE with > #ifndef _GNU_SOURCE first, then induce the change to CFLAGS in lib.mk. > That would prevent a partial merge from triggering build warnings. Please drop this series. thanks, -- Shuah