From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8311BC43387 for ; Mon, 14 Jan 2019 21:35:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5903020659 for ; Mon, 14 Jan 2019 21:35:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726863AbfANVfh (ORCPT ); Mon, 14 Jan 2019 16:35:37 -0500 Received: from gateway30.websitewelcome.com ([192.185.149.4]:13666 "EHLO gateway30.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfANVfh (ORCPT ); Mon, 14 Jan 2019 16:35:37 -0500 X-Greylist: delayed 1202 seconds by postgrey-1.27 at vger.kernel.org; Mon, 14 Jan 2019 16:35:37 EST Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway30.websitewelcome.com (Postfix) with ESMTP id A4A144D4A1 for ; Mon, 14 Jan 2019 15:15:34 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id j9a2gEMmwYTGMj9a2gyZQO; Mon, 14 Jan 2019 15:15:34 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=50914 helo=[192.168.43.131]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gj9a2-000gNf-8a; Mon, 14 Jan 2019 15:15:34 -0600 Subject: Re: [PATCH] capabilities:: annotate implicit fall through To: Mathieu Malaterre , Serge Hallyn Cc: linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190114202835.15878-1-malat@debian.org> From: "Gustavo A. R. Silva" Message-ID: <7cba59f5-d59a-f8fe-9717-0ecbab47eeaf@embeddedor.com> Date: Mon, 14 Jan 2019 15:15:30 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190114202835.15878-1-malat@debian.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1gj9a2-000gNf-8a X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.43.131]) [189.250.130.205]:50914 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 20 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 1/14/19 2:28 PM, Mathieu Malaterre wrote: > There is a plan to build the kernel with -Wimplicit-fallthrough and > this place in the code produced a warning (W=1). > > In this particular case change put the fall through comment on a single > line so as to match the regular expression expected by GCC. > > This commit remove the following warning: > > kernel/capability.c:95:3: warning: this statement may fall through [-Wimplicit-fallthrough=] > > Signed-off-by: Mathieu Malaterre Acked-by: Gustavo A. R. Silva Thanks > --- > kernel/capability.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/kernel/capability.c b/kernel/capability.c > index 1e1c0236f55b..e60be18b98e2 100644 > --- a/kernel/capability.c > +++ b/kernel/capability.c > @@ -93,9 +93,7 @@ static int cap_validate_magic(cap_user_header_t header, unsigned *tocopy) > break; > case _LINUX_CAPABILITY_VERSION_2: > warn_deprecated_v2(); > - /* > - * fall through - v3 is otherwise equivalent to v2. > - */ > + /* fall through - v3 is otherwise equivalent to v2. */ > case _LINUX_CAPABILITY_VERSION_3: > *tocopy = _LINUX_CAPABILITY_U32S_3; > break; >