From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.42 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794565073; b=0LrOYxgVyE73+M5DQGMJ9/ZGmciN1tO+wPZNyKfrbMCjjb5FDhe7tNTsLyFJrxq6qxt2 lrde1nAAnpghMU9W2vQ5UY0X6nzSSRCZFwl+pdKd373L5Q9r2RiqAUSXhEu0Mpk2qwJji gq/zoEvxXEtlf5Ttfj1J3QG4JlBQmq46l288uxQmB8f/4jD2wBf42FwZMzGafmp6oR38x 1m1yOGGS9le2MrWq9k2VeL2h4egLhrU8mTebvpoEFM9wacSZXuHYurI0gUX3CZETn7Z7G ubtG+tk1saqqGnQyU+R58bEA9rLd9pqcWVKsRiweedf22xNP/R0IpvtAj7Zz8e+rnyw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794565073; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:Content-Transfer-Encoding:User-Agent:MIME-Version; bh=zqPqkCGOaO5RL/5NE1UeXRxAO7AqEHmUDDsiHSGxDsA=; b=Nza3JfMRVgoxsnUIUVOAE68/77SV0VqHkTq6vWlr3B5bi4nkDaqk2xFEbs1B9GV9U0fT vQGDK4DWWjeeHGkxB+Fr2x7Xw3ynnVQUhUS2G7XlBlC3d24ljl5okyXwmcudjJA20g/in XwV6/BZ0YKVi9k0DFcNbPhS48GwdKv664oxCUNuyxDFcgT0BKk/b4kP9zT26DCt7zjaT7 zZ8DoreHQDxdP5XGcUm6TOTeAQtpyGZ8VWcExhXRhTtvqTfmE2inzvUgRpFYmZnOg4oCp /mQi335WjfJma9PiCYiOE+bKT13gzZN0OqPg91BWo1JmzGA+a4mSkdTnsPdbnmI2duw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=amutable.com; spf=pass smtp.mailfrom=amutable.com; dkim=pass header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=hEEG7fG6; arc=none smtp.remote-ip=209.85.128.42 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BD7F606A337 for ; Fri, 13 Nov 2026 10:17:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 5BD7F606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=amutable.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amutable.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amutable-com.20260707.gappssmtp.com header.i=@amutable-com.20260707.gappssmtp.com header.a=rsa-sha256 header.s=20260707 header.b=hEEG7fG6 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4a2d6d01ecbso7049435e9.0 for ; Fri, 13 Nov 2026 02:17:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amutable-com.20260707.gappssmtp.com; s=20260707; t=1794565072; x=1795169872; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to:content-type; bh=zqPqkCGOaO5RL/5NE1UeXRxAO7AqEHmUDDsiHSGxDsA=; b=hEEG7fG6RzQkOoGSL66zkn+hWpy0b8TxpW+CxGFBwGxbhLfdgmFqwESmbjaY7MScGa 1TTEC4ZDzMo/nTmQbATUq4OC5CVK8FiegRjrCOceUr+V68t+3IyOPEhrmauT/typpuMH 7BtZ7bLX9twnpc3pST7EzNdPnkg3BFhqHXhYG5RTwPNXEKUOMAEYxir+CLBCGEbp4xnq ot2tG8XA7sYEn5cZCga4RcL6w3I4tCQX2A1rGgTmCQohN7lvb4NCOhavzOt0i7fRXz7K 0fiOYrUI/s1Mo3f+qCL5v2ciULr5WU1WUhy3OFmgCMCM2mU4bZM+JgAT1J65gELN03wt 2Tdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794565072; x=1795169872; h=mime-version:user-agent:content-transfer-encoding:content-type :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zqPqkCGOaO5RL/5NE1UeXRxAO7AqEHmUDDsiHSGxDsA=; b=KDH5ClxxCr/sHO3nQ2jK9i+wiauZBInxnn984J2wZSTp0dCsOOT7EA+8c5rRyheHXK Lvj/veoKMqJBzCiZSoMzEsoigNahzozBS40tRVKrQZJ07vQ6YhYXaatOvgYYO8gB1eDl 6bTNsVDofxeG6GOqSgmJvw+1aPuRVVm6+FIjFk6iPTU65yj0vi4RKzJav0OmNVtzYQQ6 5QeefYjU7N7ZU10Mzv4NAaCL0+4wZhpES6m69pvQQsWfKG/pVpzOwJzISWfHGNxcVp5i YeQbdp3h1f2ZeTFWWwIvTClMbB3JPC8T5HVW+lK8LfXtN+57Y8yRzLOgqz3lM/9/gqZV E4+w== X-Forwarded-Encrypted: i=1; AL+hErGrY1reFY2iqhuSIOIQYmBeOuyHd4azTjQjWa6fD748DL+Egulm8FZYJLnXZ+3+dgJxysaU3ByVyF/AqiFbSX6miGGzG08=@vger.kernel.org X-Gm-Message-State: APuU4Z8hP3qZoNFRzfctbox+nnGf3UuCCbR7euu2CVigzJg9rj7+gxxw qQChA2fax0qNVWRpjJMf7XdVOv+Yk7ClwpPE64UB8/ZvLa1OmTpdvHHAnWgYF3W3cm2d X-Gm-Gg: AYBFou2bC/EtvLMf16vvxMksUMm62BmISOZPDYE0Rr5H+w87glsnIpdk+krwbI8H34t LzZkTvflYmLWicWree8Ubfhpw80iVo/JROW6PKnUBYr5/eblpKndYffXHpD9GwTDjJs45MD8Jfd PvfR0blNBvu+6k91sbwBiXlhgLA0Id4UzDUi5KWK+D/cmQnk+794pGd0CS+ESCp2JHyvmXapTE8 kHU50ROOwy8EVxYUGjxmdtRJqQqGQvDcOqQ4NQFRaJp4PMR+MM2z7K//CKXw66Yp3IJijb1PioF 6zUYrAFVOCoNFOxflLW+8bWIlTNebgmz2wimzya4gj73hwU7rMQMJcYAFuPq7+g/n3x9Oc+FDpN Gu/V2AMAUZsdHRbK6nEY1k/OdCVIQPUszdGuRyBh10sxb0WeW9KOAN/S1Jf2lh8cr/0GAIgjU56 vsgw/SJaQwg1hs1TMDxGtS1DuLikuIjfJi8jmdluLbPnIC3AHo+qsfelrM6riw2ngJYQitLiQUq jzMtMpyz1CmPcOyIzLMI0P9IQFII8DT3uliyfl6GsIpyGVUZfuWf60PnMew20pVYahg10kgqmnY v5DSXVICWS1jBbGj6DmKJfcOZlI4is+8l540zVvk3XE6p6+6lVUON+116BwAaK8= X-Received: by 2002:a05:600c:45d4:b0:4a0:23f:8b0d with SMTP id 5b1f17b1804b1-4bb559f6f31mr43851425e9.2.1794565071804; Fri, 13 Nov 2026 02:17:51 -0800 (PST) Received: from [10.0.0.233] (tmo-086-54.customers.d1-online.com. [80.187.86.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-49c7da37b19sm3937770f8f.5.2026.11.13.02.17.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Nov 2026 02:17:51 -0800 (PST) Message-ID: <7cde6f3091f9d90593e4a6441723b6b889cc4024.camel@amutable.com> Subject: Re: [PATCH RFC 35/41] zloop: refuse zone files on pseudo filesystems From: Alexander Mikhalitsyn To: Christian Brauner , linux-fsdevel@vger.kernel.org Cc: Jann Horn , Chris Mason , Josef Bacik , Christoph Hellwig , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Alexander Viro , Jan Kara , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, driver-core@lists.linux.dev, linux-mm@kvack.org, bpf@vger.kernel.org, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, apparmor@lists.ubuntu.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, fuse-devel@lists.linux.dev, linux-efi@vger.kernel.org, xen-devel@lists.xenproject.org, ocfs2-devel@lists.linux.dev, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, Amir Goldstein , linux-erofs@lists.ozlabs.org, linux-kselftest@vger.kernel.org Date: Fri, 13 Nov 2026 11:17:48 +0100 In-Reply-To: <20261110-work-loop-pseudo-v1-35-4c998976c6c7@kernel.org> References: <20261110-work-loop-pseudo-v1-0-4c998976c6c7@kernel.org> <20261110-work-loop-pseudo-v1-35-4c998976c6c7@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 On Tue, 2026-11-10 at 10:14 +0100, Christian Brauner wrote: > zloop opens its zone files by name below the base directory but a > bind > mount can put any file there, including a procfs or sysfs file. > Refuse > files on pseudo filesystems as zone files just like loop does. >=20 > Signed-off-by: Christian Brauner (Amutable) Reviewed-by: Alexander Mikhalitsyn > --- > =C2=A0drivers/block/zloop.c | 5 +++++ > =C2=A01 file changed, 5 insertions(+) >=20 > diff --git a/drivers/block/zloop.c b/drivers/block/zloop.c > index 65634a39b0bf..dcc06dd47b04 100644 > --- a/drivers/block/zloop.c > +++ b/drivers/block/zloop.c > @@ -1137,6 +1137,11 @@ static int zloop_init_zone(struct zloop_device > *zlo, struct zloop_options *opts, > =C2=A0 goto out_fput; > =C2=A0 } > =C2=A0 > + if (file_is_pseudo(zone->file)) { > + ret =3D -EINVAL; > + goto out_fput; > + } > + > =C2=A0 if (zlo->block_size) { > =C2=A0 ret =3D zloop_get_block_size(zlo, zone); > =C2=A0 if (ret)