* [PATCH v2] ima/evm: Fix potential memory leak in ima_init_crypto()
@ 2022-07-12 1:10 Jianglei Nie
2022-07-12 11:40 ` Mimi Zohar
0 siblings, 1 reply; 2+ messages in thread
From: Jianglei Nie @ 2022-07-12 1:10 UTC (permalink / raw)
To: zohar, dmitry.kasatkin, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel,
Jianglei Nie
On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
without freeing the ima_algo_array. Add the missing kfree() for
ima_algo_array to avoid the potential memory leak.
Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
---
security/integrity/ima/ima_crypto.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/integrity/ima/ima_crypto.c b/security/integrity/ima/ima_crypto.c
index a7206cc1d7d1..64499056648a 100644
--- a/security/integrity/ima/ima_crypto.c
+++ b/security/integrity/ima/ima_crypto.c
@@ -205,6 +205,7 @@ int __init ima_init_crypto(void)
crypto_free_shash(ima_algo_array[i].tfm);
}
+ kfree(ima_algo_array);
out:
crypto_free_shash(ima_shash_tfm);
return rc;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ima/evm: Fix potential memory leak in ima_init_crypto()
2022-07-12 1:10 [PATCH v2] ima/evm: Fix potential memory leak in ima_init_crypto() Jianglei Nie
@ 2022-07-12 11:40 ` Mimi Zohar
0 siblings, 0 replies; 2+ messages in thread
From: Mimi Zohar @ 2022-07-12 11:40 UTC (permalink / raw)
To: Jianglei Nie, dmitry.kasatkin, jmorris, serge
Cc: linux-integrity, linux-security-module, linux-kernel
On Tue, 2022-07-12 at 09:10 +0800, Jianglei Nie wrote:
> On failure to allocate the SHA1 tfm, IMA fails to initialize and exits
> without freeing the ima_algo_array. Add the missing kfree() for
> ima_algo_array to avoid the potential memory leak.
>
> Signed-off-by: Jianglei Nie <niejianglei2021@163.com>
Thanks, Jianglei. This patch is now queued in next-integrity/next-
integrity-testing.
Mimi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-12 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-07-12 1:10 [PATCH v2] ima/evm: Fix potential memory leak in ima_init_crypto() Jianglei Nie
2022-07-12 11:40 ` Mimi Zohar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).