From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D8C2376FD; Mon, 23 Feb 2026 15:00:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771858856; cv=none; b=B028ajxOkXYQqrYMajrVe3MMo8b+eYTTR8SCkIHOFxz7/iiI86gkokNhtloowQd0Wn8JYgc153r/NYVFaTsvXxmFJDMFMYoaG0TtVppYiYZSuDppnU1toK5xSZ3VIAEY/o5RsstUpN5D/kTfKR+RyJx81ypjNUR1GAYAjeHTq9Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771858856; c=relaxed/simple; bh=LZJWPyqc7zRDNeLJ/kaMnDCbQKW6iC+a3VJo41M3xIE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=ofvs7gsyLXnkSr8BiOhqnIBjPuDBAMsRC93LmBHWm6FMkBMWvlGEYl0F55fzlKmn5X6X0ka02qpanxclmFkJeRHTb+gdIB7o59bfS4vcyGTCW3sAMNge4z6qyCEJAOQ8zuc+LaW4y/+0pcIRuC1CvvOiuO8llYnbEUHheVmh4bk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ubEKdO1F; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ubEKdO1F" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 69B72C116C6; Mon, 23 Feb 2026 15:00:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1771858856; bh=LZJWPyqc7zRDNeLJ/kaMnDCbQKW6iC+a3VJo41M3xIE=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=ubEKdO1FeQU4KehKkk4Ha+sWn8rhfohWnTzrm5CQTdxfLOh0UTSboTY5F7p1nHvdb c9CXLVWjqNOPyM3IFuKtP5z1azU7USMNNrUpB7SeVFwk3RoAJYzLxs1vztVb8aZ0Dg +JUgamzo3UrhAJN82wQ+cEgtBc6YV+GtEuO3fPoqKYljQW/zE+0q9rjOMZyhojRUaX oaVPUfn3nyPnD1VlIIcPzhKN1gu3nthfg40z8QQBwjBa2qQIklIls4ZYFZ4SJgFW3H mMimssaZEdP8xcE7negFA4+KTvkjEOlgRnMa7kVg1pSO+AhJHvtIApe4ftxUg+oYUJ HNgCcU376zbaw== From: Andreas Hindborg To: Alice Ryhl Cc: Miguel Ojeda , Gary Guo , =?utf-8?Q?Bj=C3=B6rn?= Roy Baron , Benno Lossin , Trevor Gross , Danilo Krummrich , Greg Kroah-Hartman , Dave Ertman , Ira Weiny , Leon Romanovsky , Paul Moore , Serge Hallyn , "Rafael J. Wysocki" , David Airlie , Simona Vetter , Alexander Viro , Christian Brauner , Jan Kara , Igor Korotin , Daniel Almeida , Lorenzo Stoakes , "Liam R. Howlett" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Bjorn Helgaas , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Boqun Feng , linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-security-module@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-pci@vger.kernel.org, Oliver Mangold Subject: Re: [PATCH v15 3/9] rust: Add missing SAFETY documentation for `ARef` example In-Reply-To: References: <20260220-unique-ref-v15-0-893ed86b06cc@kernel.org> <20260220-unique-ref-v15-3-893ed86b06cc@kernel.org> Date: Mon, 23 Feb 2026 15:59:52 +0100 Message-ID: <87v7fn33pz.fsf@t14s.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alice Ryhl writes: > On Fri, Feb 20, 2026 at 10:52=E2=80=AFAM Andreas Hindborg wrote: >> >> From: Oliver Mangold >> >> SAFETY comment in rustdoc example was just 'TODO'. Fixed. >> >> Signed-off-by: Oliver Mangold >> Reviewed-by: Daniel Almeida >> Co-developed-by: Andreas Hindborg >> Signed-off-by: Andreas Hindborg >> --- >> rust/kernel/sync/aref.rs | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/rust/kernel/sync/aref.rs b/rust/kernel/sync/aref.rs >> index 61caddfd89619..efe16a7fdfa5d 100644 >> --- a/rust/kernel/sync/aref.rs >> +++ b/rust/kernel/sync/aref.rs >> @@ -129,12 +129,14 @@ pub unsafe fn from_raw(ptr: NonNull) -> Self { >> /// # Examples >> /// >> /// ``` >> - /// use core::ptr::NonNull; >> - /// use kernel::sync::aref::{ARef, RefCounted}; >> + /// # use core::ptr::NonNull; >> + /// # use kernel::sync::aref::{ARef, RefCounted}; >> /// > > Either keep the imports visible or delete this empty line. And either > way, it doesn't really fit in this commit. I'll drop this for this commit. Best regards, Andreas Hindborg