From: Martin KaFai Lau <martin.lau@linux.dev>
To: Geliang Tang <geliang.tang@suse.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
mptcp@lists.linux.dev, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Yonghong Song <yonghong.song@linux.dev>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Florent Revest <revest@chromium.org>,
Brendan Jackman <jackmanb@chromium.org>,
Matthieu Baerts <matthieu.baerts@tessares.net>,
Mat Martineau <martineau@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
John Johansen <john.johansen@canonical.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Eric Paris <eparis@parisplace.org>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp
Date: Fri, 4 Aug 2023 17:23:32 -0700 [thread overview]
Message-ID: <8b706f66-2afa-b3d0-a13a-11f1ffb452fe@linux.dev> (raw)
In-Reply-To: <15d7646940fcbb8477b1be1aa11a5d5485d10b48.1691125344.git.geliang.tang@suse.com>
On 8/3/23 10:07 PM, Geliang Tang wrote:
> Use rand() to generate a random netns name instead of using the fixed
> name "mptcp_ns" for every test.
>
> By doing that, we can re-launch the test even if there was an issue
> removing the previous netns or if by accident, a netns with this generic
> name already existed on the system.
>
> Note that using a different name each will also help adding more
> subtests in future commits.
I run test_progs repeatedly without rebooting qemu to save time. If there is a
test did not clean up its netns, I would rather uncover it earlier and fix it
instead. Randomizing the name is hiding the issue and does not help to uncover
the broken test sooner. Although this change is to mptcp test alone, this could
be referred in other future tests.
afaik, I don't remember bpf CI ever run into a test failure because the picked
name had already been used by the system. It seems you ran into this issue a lot
with the mptcp test in your setup. Could you explain a little more?
next prev parent reply other threads:[~2023-08-05 0:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 5:07 [PATCH bpf-next v11 0/5] bpf: Force to MPTCP Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 1/5] bpf: Add update_socket_protocol hook Geliang Tang
2023-08-05 0:00 ` Martin KaFai Lau
2023-08-04 5:07 ` [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp Geliang Tang
2023-08-05 0:23 ` Martin KaFai Lau [this message]
2023-08-07 6:40 ` Geliang Tang
2023-08-09 6:03 ` Martin KaFai Lau
2023-08-09 8:19 ` Geliang Tang
2023-08-11 5:53 ` Martin KaFai Lau
2023-08-11 9:29 ` Geliang Tang
2023-08-11 18:50 ` Martin KaFai Lau
2023-08-04 5:07 ` [PATCH bpf-next v11 3/5] selftests/bpf: Add two mptcp netns helpers Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 4/5] selftests/bpf: Drop unneeded checks for mptcp Geliang Tang
2023-08-04 5:07 ` [PATCH bpf-next v11 5/5] selftests/bpf: Add mptcpify test Geliang Tang
2023-08-05 0:40 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8b706f66-2afa-b3d0-a13a-11f1ffb452fe@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=apparmor@lists.ubuntu.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eparis@parisplace.org \
--cc=geliang.tang@suse.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=jackmanb@chromium.org \
--cc=jmorris@namei.org \
--cc=john.fastabend@gmail.com \
--cc=john.johansen@canonical.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul@paul-moore.com \
--cc=revest@chromium.org \
--cc=sdf@google.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=stephen.smalley.work@gmail.com \
--cc=yhs@fb.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).