From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 135F7C04A94 for ; Sat, 5 Aug 2023 00:31:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229729AbjHEAbT (ORCPT ); Fri, 4 Aug 2023 20:31:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjHEAbS (ORCPT ); Fri, 4 Aug 2023 20:31:18 -0400 X-Greylist: delayed 451 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Fri, 04 Aug 2023 17:31:17 PDT Received: from out-81.mta0.migadu.com (out-81.mta0.migadu.com [91.218.175.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F3304ED3 for ; Fri, 4 Aug 2023 17:31:17 -0700 (PDT) Message-ID: <8b706f66-2afa-b3d0-a13a-11f1ffb452fe@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691195024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eUPA7Rbj5jk/MQgWgg+tKqw5KVGmICrIzOFj3UTUAGM=; b=FMHWlSfzy1ema2iNWXS3cVRO55vunCyX23YpRCcUf0/fa1sl2w6jsF7fSBZwDCRpY8O/D/ 5rP/MpM2zW1gjLe3Tz2hWCPiehr5qwYBnHJysFDtQgOo4Y6t6HPHYVjqdEbz9hyzVcknx6 GC0H0RtkOPxfj0cMf2/v1V6Oje/VOlo= Date: Fri, 4 Aug 2023 17:23:32 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp Content-Language: en-US To: Geliang Tang Cc: bpf@vger.kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org, Yonghong Song , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Florent Revest , Brendan Jackman , Matthieu Baerts , Mat Martineau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Mykola Lysenko , Shuah Khan , Simon Horman References: <15d7646940fcbb8477b1be1aa11a5d5485d10b48.1691125344.git.geliang.tang@suse.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <15d7646940fcbb8477b1be1aa11a5d5485d10b48.1691125344.git.geliang.tang@suse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: On 8/3/23 10:07 PM, Geliang Tang wrote: > Use rand() to generate a random netns name instead of using the fixed > name "mptcp_ns" for every test. > > By doing that, we can re-launch the test even if there was an issue > removing the previous netns or if by accident, a netns with this generic > name already existed on the system. > > Note that using a different name each will also help adding more > subtests in future commits. I run test_progs repeatedly without rebooting qemu to save time. If there is a test did not clean up its netns, I would rather uncover it earlier and fix it instead. Randomizing the name is hiding the issue and does not help to uncover the broken test sooner. Although this change is to mptcp test alone, this could be referred in other future tests. afaik, I don't remember bpf CI ever run into a test failure because the picked name had already been used by the system. It seems you ran into this issue a lot with the mptcp test in your setup. Could you explain a little more?