From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90DE2C433FF for ; Fri, 2 Aug 2019 16:11:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 663B22173E for ; Fri, 2 Aug 2019 16:11:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390127AbfHBQLL (ORCPT ); Fri, 2 Aug 2019 12:11:11 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:33111 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732543AbfHBQLL (ORCPT ); Fri, 2 Aug 2019 12:11:11 -0400 Received: from LHREML714-CAH.china.huawei.com (unknown [172.18.7.107]) by Forcepoint Email with ESMTP id C1C8DC64785C6836DBC4; Fri, 2 Aug 2019 17:11:09 +0100 (IST) Received: from [10.220.135.74] (10.220.135.74) by smtpsuk.huawei.com (10.201.108.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Aug 2019 17:11:03 +0100 Subject: Re: [PATCH v2] KEYS: trusted: allow module init if TPM is inactive or deactivated From: Roberto Sassu To: Tyler Hicks CC: , , , , , , , , , , References: <20190802150733.1972-1-roberto.sassu@huawei.com> <20190802153030.GB26616@elm> <3222714a-a280-0708-f4c0-5db6d342d8dc@huawei.com> Message-ID: <8baf1c39-ad04-5cd6-bc67-341e7411db16@huawei.com> Date: Fri, 2 Aug 2019 18:11:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <3222714a-a280-0708-f4c0-5db6d342d8dc@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.220.135.74] X-CFilter-Loop: Reflected Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 8/2/2019 5:34 PM, Roberto Sassu wrote: > On 8/2/2019 5:30 PM, Tyler Hicks wrote: >> On 2019-08-02 17:07:33, Roberto Sassu wrote: >>> Commit c78719203fc6 ("KEYS: trusted: allow trusted.ko to initialize >>> w/o a >>> TPM") allows the trusted module to be loaded even a TPM is not found to >>                                                     ^ if >> >>> avoid module dependency problems. >>> >>> However, trusted module initialization can still fail if the TPM is >>> inactive or deactivated. This patch ignores tpm_get_random() errors in >>> init_digests() and returns -EFAULT in pcrlock() if the TPM didn't return >>> random data. >>> >>> Signed-off-by: Roberto Sassu >> >> The code changes look correct to me. >> >>    Reviewed-by: Tyler Hicks >> >> For whoever takes this patch through their tree, I think that adding the >> following Fixes tag would be useful (as well as cc'ing stable): >> >>    Fixes: 240730437deb ("KEYS: trusted: explicitly use tpm_chip >> structure...") >> >> I think it is also worth leaving a short note, in the commit message, >> for backporters that commit 782779b60faa ("tpm: Actually fail on TPM >> errors during "get random"") should be included with any backports of >> this patch. > > Right, thanks. I wait for Jarkko's comments and I add both the Fixes tag > and the short note in the next version of the patch. Uhm, I was thinking that maybe it is not necessary to mention commit 782779b60faa. This patch would still return 0 even if that commit is not backported (TPM_ERR_DISABLED < TPM_MAX_DIGEST_SIZE). Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli