From: Mark Brown <broonie@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Kees Cook" <kees@kernel.org>, "Mickaël Salaün" <mic@digikod.net>,
"Günther Noack" <gnoack@google.com>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
"Ard Biesheuvel" <ardb@kernel.org>
Subject: Re: [PATCH] gcc-plugins: Disable GCC plugins for compile test builds
Date: Mon, 7 Apr 2025 23:02:15 +0100 [thread overview]
Message-ID: <8cbe0cac-2952-47b6-9b0d-1400aec0bf25@sirena.org.uk> (raw)
In-Reply-To: <CAHk-=wjTbWiYwfj2wF9iP8SSVk2A_cZFDr5hu1bgU_PfxhyiiA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]
On Mon, Apr 07, 2025 at 02:33:40PM -0700, Linus Torvalds wrote:
> On Mon, 7 Apr 2025 at 14:10, Mark Brown <broonie@kernel.org> wrote:
> > Arnd bisected this to c56f649646ec ("landlock: Log mount-related
> > denials") but that commit is fairly obviously not really at fault here,
> > most likely this is an issue in the plugin. Given how disruptive having
> > key configs like this failing let's disable the plugins for compile test
> > builds until a fix is found.
> I'm not against this, but I do want to bring up the "are the plugins
> worth having at all" discussion again.
> They've been a pain before. Afaik, the actual useful cases are now
> done by actual real compiler support (and by clang, at that).
> Who actually *uses* the gcc plugins? They just worry me in general,
> and this is not the first time they have caused ICE problems.
There was a bit of discussion of that on IRC which didn't summon up huge
enthusiasm for them. Arnd noted that:
https://github.com/nyrahul/linux-kernel-configs
indicates that Talos 1.9.1 uses latent_entropy (but we didn't check how
accurate that survey is). He also noted that GCC_PLUGIN_SANCOV is
obsolete as of GCC 6 (!) and both CC_HAVE_STACKPROTECTOR_TLS and
GCC_PLUGIN_STRUCTLEAK_BYREF_ALL as of GCC 12, Ard indicated he wasn't
worried about loosing CC_HAVE_STACKPROTECTOR_TLS.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-04-07 22:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 20:57 [PATCH] gcc-plugins: Disable GCC plugins for compile test builds Mark Brown
2025-04-07 21:33 ` Linus Torvalds
2025-04-07 22:02 ` Mark Brown [this message]
2025-04-08 9:22 ` Arnd Bergmann
2025-04-08 20:37 ` Kees Cook
2025-04-10 7:58 ` Arnd Bergmann
2025-04-08 23:32 ` Kees Cook
2025-04-09 5:43 ` Arnd Bergmann
2025-04-09 12:19 ` Mark Brown
2025-04-09 15:33 ` Linus Torvalds
2025-04-09 17:29 ` Mark Brown
2025-04-09 17:42 ` Linus Torvalds
2025-04-09 17:46 ` Kees Cook
2025-04-09 18:09 ` Mark Brown
2025-04-09 19:24 ` Arnd Bergmann
2025-04-15 20:26 ` Palmer Dabbelt
2025-04-15 20:41 ` Mark Brown
2025-04-15 20:43 ` Kees Cook
2025-04-15 20:41 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cbe0cac-2952-47b6-9b0d-1400aec0bf25@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=gnoack@google.com \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox