From: Jeff Layton <jlayton@kernel.org>
To: NeilBrown <neil@brown.name>,
Christian Brauner <brauner@kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>, Jan Kara <jack@suse.cz>,
Chuck Lever <chuck.lever@oracle.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Amir Goldstein <amir73il@gmail.com>,
John Johansen <john.johansen@canonical.com>,
Paul Moore <paul@paul-moore.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>
Cc: linux-kernel@vger.kernel.org, netfs@lists.linux.dev,
linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH 03/13] libfs: change simple_done_creating() to use end_creating()
Date: Thu, 05 Feb 2026 07:19:45 -0500 [thread overview]
Message-ID: <8d907c67ccab1db0e7bcabe0c34c66722a2970e2.camel@kernel.org> (raw)
In-Reply-To: <20260204050726.177283-4-neilb@ownmail.net>
On Wed, 2026-02-04 at 15:57 +1100, NeilBrown wrote:
> From: NeilBrown <neil@brown.name>
>
> simple_done_creating() and end_creating() are identical.
> So change the former to use the latter. This further centralises
> unlocking of directories.
>
> Signed-off-by: NeilBrown <neil@brown.name>
> ---
> fs/libfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/libfs.c b/fs/libfs.c
> index f1860dff86f2..db18b53fc189 100644
> --- a/fs/libfs.c
> +++ b/fs/libfs.c
> @@ -2318,7 +2318,6 @@ EXPORT_SYMBOL(simple_start_creating);
> /* parent must have been held exclusive since simple_start_creating() */
> void simple_done_creating(struct dentry *child)
> {
> - inode_unlock(child->d_parent->d_inode);
> - dput(child);
> + end_creating(child);
> }
> EXPORT_SYMBOL(simple_done_creating);
nit: seems like it would be better to turn this into a static inline
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2026-02-05 12:19 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 4:57 [PATCH 00/13] Further centralising of directory locking for name ops NeilBrown
2026-02-04 4:57 ` [PATCH 01/13] fs/proc: Don't lock root inode when creating "self" and "thread-self" NeilBrown
2026-02-05 12:33 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 02/13] VFS: move the start_dirop() kerndoc comment to before start_dirop() NeilBrown
2026-02-05 12:33 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 03/13] libfs: change simple_done_creating() to use end_creating() NeilBrown
2026-02-05 12:19 ` Jeff Layton [this message]
2026-02-06 2:13 ` NeilBrown
2026-02-04 4:57 ` [PATCH 04/13] Apparmor: Use simple_start_creating() / simple_done_creating() NeilBrown
2026-02-04 10:58 ` kernel test robot
2026-02-05 12:58 ` Jeff Layton
2026-02-06 0:21 ` NeilBrown
2026-02-04 4:57 ` [PATCH 05/13] selinux: " NeilBrown
2026-02-05 12:36 ` Jeff Layton
2026-02-20 22:47 ` Paul Moore
2026-02-21 22:28 ` NeilBrown
2026-02-22 14:19 ` Paul Moore
2026-02-23 0:58 ` NeilBrown
2026-02-04 4:57 ` [PATCH 06/13] nfsd: switch purge_old() to use start_removing_noperm() NeilBrown
2026-02-05 12:36 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 07/13] VFS: make lookup_one_qstr_excl() static NeilBrown
2026-02-05 12:37 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 08/13] ovl: Simplify ovl_lookup_real_one() NeilBrown
2026-02-05 12:38 ` Jeff Layton
2026-02-05 13:04 ` Amir Goldstein
2026-02-06 0:43 ` NeilBrown
2026-02-04 4:57 ` [PATCH 09/13] cachefiles: change cachefiles_bury_object to use start_renaming_dentry() NeilBrown
2026-02-05 12:38 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 10/13] ovl: change ovl_create_real() to get a new lock when re-opening created file NeilBrown
2026-02-05 12:26 ` Amir Goldstein
2026-02-06 1:11 ` NeilBrown
2026-02-06 13:35 ` Amir Goldstein
2026-02-04 4:57 ` [PATCH 11/13] ovl: use is_subdir() for testing if one thing is a subdir of another NeilBrown
2026-02-05 9:37 ` Amir Goldstein
2026-02-05 12:38 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 12/13] ovl: remove ovl_lock_rename_workdir() NeilBrown
2026-02-05 9:45 ` Amir Goldstein
2026-02-06 1:18 ` NeilBrown
2026-02-05 12:40 ` Jeff Layton
2026-02-05 12:58 ` Jeff Layton
2026-02-04 4:57 ` [PATCH 13/13] VFS: unexport lock_rename(), lock_rename_child(), unlock_rename() NeilBrown
2026-02-05 12:41 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d907c67ccab1db0e7bcabe0c34c66722a2970e2.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=amir73il@gmail.com \
--cc=apparmor@lists.ubuntu.com \
--cc=brauner@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dhowells@redhat.com \
--cc=jack@suse.cz \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=neil@brown.name \
--cc=netfs@lists.linux.dev \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox