From: Mimi Zohar <zohar@linux.ibm.com>
To: "Mickaël Salaün" <mic@digikod.net>
Cc: Paul Moore <paul@paul-moore.com>,
linux-integrity@vger.kernel.org, roberto.sassu@huawei.com,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Jeff Xu <jeffxu@chromium.org>,
Kees Cook <kees@kernel.org>,
audit@vger.kernel.org
Subject: Re: [PATCH v2] ima: instantiate the bprm_creds_for_exec() hook
Date: Tue, 10 Dec 2024 11:47:54 -0500 [thread overview]
Message-ID: <983114dbf101b0df7d61a31af002783d06fc963d.camel@linux.ibm.com> (raw)
In-Reply-To: <20241210.Wie6ion7Aich@digikod.net>
On Tue, 2024-12-10 at 17:34 +0100, Mickaël Salaün wrote:
> > > > +++ b/include/uapi/linux/audit.h
> > > > @@ -161,6 +161,7 @@
> > > > #define AUDIT_INTEGRITY_RULE 1805 /* policy rule */
> > > > #define AUDIT_INTEGRITY_EVM_XATTR 1806 /* New EVM-covered xattr */
> > > > #define AUDIT_INTEGRITY_POLICY_RULE 1807 /* IMA policy rules */
> > > > +#define AUDIT_INTEGRITY_DATA_CHECK 1808 /* Userspace enforced data integrity */
> > >
> > > I worry that "DATA_CHECK" is a bit vague, should we change the name so
> > > that there is some hint of either userspace enforcement or
> > > AT_EXECVE_CHECK?
> > >
> > > What about AUDIT_INTEGRITY_DATA_USER?
> >
> > The emphasis should be on userspace - AUDIT_INTEGRITY_USERSPACE.
>
> Looks good, I'll send a new patch series with this change, following
> https://lore.kernel.org/all/20241205160925.230119-9-mic@digikod.net/
Sound good! Thank you.
Mimi
next prev parent reply other threads:[~2024-12-10 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 19:25 [PATCH v2] ima: instantiate the bprm_creds_for_exec() hook Mimi Zohar
2024-12-04 19:27 ` Mimi Zohar
2024-12-06 0:30 ` Paul Moore
2024-12-06 3:10 ` Mimi Zohar
2024-12-10 16:34 ` Mickaël Salaün
2024-12-10 16:47 ` Mimi Zohar [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-12-03 23:34 Mimi Zohar
2024-12-04 10:15 ` Mickaël Salaün
2024-12-04 14:57 ` Mimi Zohar
2024-12-04 17:47 ` Mickaël Salaün
2024-12-04 19:01 ` Stefan Berger
2024-12-05 10:53 ` Mickaël Salaün
2024-12-05 15:44 ` Stefan Berger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=983114dbf101b0df7d61a31af002783d06fc963d.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=audit@vger.kernel.org \
--cc=jeffxu@chromium.org \
--cc=kees@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mic@digikod.net \
--cc=paul@paul-moore.com \
--cc=roberto.sassu@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).