From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3857CC001B0 for ; Wed, 9 Aug 2023 06:03:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230357AbjHIGDu (ORCPT ); Wed, 9 Aug 2023 02:03:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230379AbjHIGDt (ORCPT ); Wed, 9 Aug 2023 02:03:49 -0400 Received: from out-113.mta1.migadu.com (out-113.mta1.migadu.com [95.215.58.113]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5602A0 for ; Tue, 8 Aug 2023 23:03:48 -0700 (PDT) Message-ID: <9a84e026-402d-b6d9-b6d1-57d91455da47@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691561020; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vZ6V615A2KqrskAOUp1MTFIPzrZmCi/maZKOac3W810=; b=HLvjH2ogbvNYgLBEabSq0L0ndbjsUYoxG9XBVixYUkq93imGD6SmYSCQGkkV3UE5OhTso+ EuynVJbQyP4jlk0+SYzMeAGPHKZZGPYdtE87MUq04XqOcWW6VK/1DeTlun8ADzQ1RMsYo7 mF0JvS5dGjKv44EceTfYn+WeOH08Kg0= Date: Tue, 8 Aug 2023 23:03:30 -0700 MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v11 2/5] selftests/bpf: Use random netns name for mptcp Content-Language: en-US To: Geliang Tang Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Florent Revest , Brendan Jackman , Matthieu Baerts , Mat Martineau , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , Mykola Lysenko , Shuah Khan , Simon Horman , bpf@vger.kernel.org, netdev@vger.kernel.org, mptcp@lists.linux.dev, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org, linux-kselftest@vger.kernel.org References: <15d7646940fcbb8477b1be1aa11a5d5485d10b48.1691125344.git.geliang.tang@suse.com> <8b706f66-2afa-b3d0-a13a-11f1ffb452fe@linux.dev> <20230807064044.GA11180@localhost.localdomain> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20230807064044.GA11180@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: On 8/6/23 11:40 PM, Geliang Tang wrote: > On Fri, Aug 04, 2023 at 05:23:32PM -0700, Martin KaFai Lau wrote: >> On 8/3/23 10:07 PM, Geliang Tang wrote: >>> Use rand() to generate a random netns name instead of using the fixed >>> name "mptcp_ns" for every test. >>> >>> By doing that, we can re-launch the test even if there was an issue >>> removing the previous netns or if by accident, a netns with this generic >>> name already existed on the system. >>> >>> Note that using a different name each will also help adding more >>> subtests in future commits. > > Hi Martin, > > I tried to run mptcp tests simultaneously, and got "Cannot create > namespace file "/var/run/netns/mptcp_ns": File exists" errors sometimes. > So I add this patch to fix it. > > It's easy to reproduce, just run this commands in multiple terminals: > > for i in `seq 1 100`; do sudo ./test_progs -t mptcp; done Not only the "-t mptcp" test. Other tests in test_progs also don't support running parallel in multiple terminals. Does it really help to test the bpf part of the prog_tests/mptcp.c test by running like this? If it wants to exercise the other mptcp networking specific code like this, a separate mptcp test is needed outside of test_progs and it won't be run in the bpf CI. If you agree, can you please avoid introducing unnecessary randomness to the test_progs where bpf CI and most users don't run in this way? Also, please don't resend the patches too fast until the discussion is concluded. Please give reasonable time for others to reply. I have a high level question. In LPC 2022 (https://lpc.events/event/16/contributions/1354/), I recall there was idea in using bpf to make other mptcp decision/policy. Any thought and progress on this? This set which only uses bpf to change the protocol feels like an incomplete solution.