From: Paul Moore <paul@paul-moore.com>
To: Casey Schaufler <casey@schaufler-ca.com>,
casey@schaufler-ca.com, eparis@redhat.com,
linux-security-module@vger.kernel.org, audit@vger.kernel.org
Cc: jmorris@namei.org, serge@hallyn.com, keescook@chromium.org,
john.johansen@canonical.com, penguin-kernel@i-love.sakura.ne.jp,
stephen.smalley.work@gmail.com, linux-kernel@vger.kernel.org,
selinux@vger.kernel.org
Subject: Re: [PATCH RFC 13/15] LSM: restrict security_cred_getsecid() to a single LSM
Date: Tue, 14 Oct 2025 19:13:01 -0400 [thread overview]
Message-ID: <9ebb0de0d0a7b889b70e083a99c59d13@paul-moore.com> (raw)
In-Reply-To: <20250621171851.5869-14-casey@schaufler-ca.com>
On Jun 21, 2025 Casey Schaufler <casey@schaufler-ca.com> wrote:
>
> The LSM hook security_cred_getsecid() provides a single secid
> that is only used by the binder driver. Provide the first value
> available, and abandon any other hooks.
>
> Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>
> ---
> security/security.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/security/security.c b/security/security.c
> index dd167a872248..409b1cb10d35 100644
> --- a/security/security.c
> +++ b/security/security.c
> @@ -2740,8 +2740,13 @@ void security_transfer_creds(struct cred *new, const struct cred *old)
> */
> void security_cred_getsecid(const struct cred *c, u32 *secid)
> {
> + struct lsm_static_call *scall;
> +
> *secid = 0;
> - call_void_hook(cred_getsecid, c, secid);
> + lsm_for_each_hook(scall, cred_getsecid) {
> + scall->hl->hook.cred_getsecid(c, secid);
> + break;
> + }
> }
> EXPORT_SYMBOL(security_cred_getsecid);
Another case of "would this be painful to do at registration time?"
--
paul-moore.com
next prev parent reply other threads:[~2025-10-14 23:13 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250621171851.5869-1-casey.ref@schaufler-ca.com>
2025-06-21 17:18 ` [RFC PATCH 00/15] LSM: No exclusive LSMs Casey Schaufler
2025-06-21 17:18 ` [RFC PATCH 01/15] Audit: Create audit_stamp structure Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 1/15] " Paul Moore
2025-10-15 5:18 ` Casey Schaufler
2025-10-15 15:01 ` Paul Moore
2025-06-21 17:18 ` [RFC PATCH 02/15] LSM: security_lsmblob_to_secctx module selection Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 2/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 03/15] Audit: Add record for multiple task security contexts Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 3/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 04/15] Audit: Add record for multiple object contexts Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 4/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 05/15] LSM: Single calls in secid hooks Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 5/15] " Paul Moore
2025-11-04 16:00 ` Casey Schaufler
2025-06-21 17:18 ` [RFC PATCH 06/15] LSM: Exclusive secmark usage Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 6/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 07/15] Audit: Call only the first of the audit rule hooks Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 7/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 08/15] AppArmor: Remove the exclusive flag Casey Schaufler
2025-06-21 17:18 ` [RFC PATCH 09/15] LSM: Add mount opts blob size tracking Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC 9/15] " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 10/15] LSM: allocate mnt_opts blobs instead of module specific data Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 11/15] LSM: Infrastructure management of the mnt_opts security blob Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 12/15] LSM: Allow reservation of netlabel Casey Schaufler
2025-10-14 23:12 ` [PATCH RFC " Paul Moore
2025-06-21 17:18 ` [RFC PATCH 13/15] LSM: restrict security_cred_getsecid() to a single LSM Casey Schaufler
2025-10-14 23:13 ` Paul Moore [this message]
2025-06-21 17:18 ` [RFC PATCH 14/15] Smack: Remove LSM_FLAG_EXCLUSIVE Casey Schaufler
2025-06-21 17:18 ` [RFC PATCH 15/15] LSM: Remove exclusive LSM flag Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ebb0de0d0a7b889b70e083a99c59d13@paul-moore.com \
--to=paul@paul-moore.com \
--cc=audit@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=eparis@redhat.com \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).