From: David Gow <davidgow@google.com>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
adilger.kernel@dilger.ca,
John Johansen <john.johansen@canonical.com>,
jmorris@namei.org, serge@hallyn.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Brendan Higgins <brendanhiggins@google.com>,
=linux-kselftest@vger.kernel.org,
KUnit Development <kunit-dev@googlegroups.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ext4@vger.kernel.org,
linux-security-module@vger.kernel.org,
Marco Elver <elver@google.com>
Subject: Re: [PATCH v2 5/6] fs: ext4: default KUNIT_* fragments to KUNIT_RUN_ALL
Date: Thu, 7 May 2020 11:22:06 +0800 [thread overview]
Message-ID: <CABVgOS==HEaYybfRTy4a9-hxGbLa_upE3WycVZ5PueOOvUOQuQ@mail.gmail.com> (raw)
In-Reply-To: <20200505102723.8120-1-anders.roxell@linaro.org>
On Tue, May 5, 2020 at 6:27 PM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> This makes it easier to enable all KUnit fragments.
>
> Adding 'if !KUNIT_RUN_ALL' so individual test can be turned of if
> someone wants that even though KUNIT_RUN_ALL is enabled.
As with the others, "test"->"tests", and "of"->"off".
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: David Gow <davidgow@google.com>
> ---
> fs/ext4/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ext4/Kconfig b/fs/ext4/Kconfig
> index 2a592e38cdfe..76785143259d 100644
> --- a/fs/ext4/Kconfig
> +++ b/fs/ext4/Kconfig
> @@ -103,9 +103,10 @@ config EXT4_DEBUG
> echo 1 > /sys/module/ext4/parameters/mballoc_debug
>
> config EXT4_KUNIT_TESTS
> - tristate "KUnit tests for ext4"
> + tristate "KUnit tests for ext4" if !KUNIT_RUN_ALL
> select EXT4_FS
> depends on KUNIT
> + default KUNIT_RUN_ALL
> help
> This builds the ext4 KUnit tests.
>
> --
> 2.20.1
>
prev parent reply other threads:[~2020-05-07 3:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 10:27 [PATCH v2 5/6] fs: ext4: default KUNIT_* fragments to KUNIT_RUN_ALL Anders Roxell
2020-05-07 3:22 ` David Gow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABVgOS==HEaYybfRTy4a9-hxGbLa_upE3WycVZ5PueOOvUOQuQ@mail.gmail.com' \
--to=davidgow@google.com \
--cc==linux-kselftest@vger.kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=anders.roxell@linaro.org \
--cc=brendanhiggins@google.com \
--cc=elver@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jmorris@namei.org \
--cc=john.johansen@canonical.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).