From: KP Singh <kpsingh@kernel.org>
To: Frederick Lawler <fred@cloudflare.com>
Cc: revest@chromium.org, jackmanb@chromium.org, ast@kernel.org,
daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com,
jmorris@namei.org, serge@hallyn.com, paul@paul-moore.com,
stephen.smalley.work@gmail.com, eparis@parisplace.org,
shuah@kernel.org, brauner@kernel.org, casey@schaufler-ca.com,
ebiederm@xmission.com, bpf@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, kernel-team@cloudflare.com,
cgzones@googlemail.com, karl@bigbadwolfsecurity.com
Subject: Re: [PATCH v4 3/4] selftests/bpf: Add tests verifying bpf lsm userns_create hook
Date: Wed, 3 Aug 2022 00:08:42 +0200 [thread overview]
Message-ID: <CACYkzJ4_MrbS-2S_R3KSZnL8h9pWnP6ih5ccKPGYxZTaESMZ2g@mail.gmail.com> (raw)
In-Reply-To: <20220801180146.1157914-4-fred@cloudflare.com>
On Mon, Aug 1, 2022 at 8:02 PM Frederick Lawler <fred@cloudflare.com> wrote:
>
> The LSM hook userns_create was introduced to provide LSM's an
> opportunity to block or allow unprivileged user namespace creation. This
> test serves two purposes: it provides a test eBPF implementation, and
> tests the hook successfully blocks or allows user namespace creation.
>
> This tests 3 cases:
>
> 1. Unattached bpf program does not block unpriv user namespace
> creation.
> 2. Attached bpf program allows user namespace creation given
> CAP_SYS_ADMIN privileges.
> 3. Attached bpf program denies user namespace creation for a
> user without CAP_SYS_ADMIN.
>
> Signed-off-by: Frederick Lawler <fred@cloudflare.com>
Looks good to me (Also checked it on vmtest.sh)
Acked-by: KP Singh <kpsingh@kernel.org>
next prev parent reply other threads:[~2022-08-02 22:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-01 18:01 [PATCH v4 0/4] Introduce security_create_user_ns() Frederick Lawler
2022-08-01 18:01 ` [PATCH v4 1/4] security, lsm: " Frederick Lawler
2022-08-02 21:47 ` KP Singh
2022-08-03 13:13 ` Frederick Lawler
2022-08-01 18:01 ` [PATCH v4 2/4] bpf-lsm: Make bpf_lsm_userns_create() sleepable Frederick Lawler
2022-08-01 23:00 ` Alexei Starovoitov
2022-08-01 23:06 ` Paul Moore
2022-08-02 21:29 ` KP Singh
2022-08-01 18:01 ` [PATCH v4 3/4] selftests/bpf: Add tests verifying bpf lsm userns_create hook Frederick Lawler
2022-08-02 22:08 ` KP Singh [this message]
2022-08-01 18:01 ` [PATCH v4 4/4] selinux: Implement " Frederick Lawler
2022-08-02 2:56 ` [PATCH v4 0/4] Introduce security_create_user_ns() Eric W. Biederman
2022-08-03 2:10 ` Paul Moore
2022-08-08 18:56 ` Eric W. Biederman
2022-08-08 19:16 ` Paul Moore
2022-08-08 19:26 ` Eric W. Biederman
2022-08-08 19:43 ` Eric W. Biederman
2022-08-08 22:47 ` Paul Moore
2022-08-09 16:07 ` Eric W. Biederman
2022-08-09 16:47 ` Paul Moore
2022-08-09 21:40 ` Eric W. Biederman
2022-08-09 22:40 ` Paul Moore
2022-08-10 0:51 ` Alexei Starovoitov
2022-08-09 17:43 ` Casey Schaufler
2022-08-09 21:52 ` Eric W. Biederman
2022-08-08 19:49 ` Paul Moore
2022-08-09 16:40 ` Eric W. Biederman
2022-08-14 15:55 ` Serge E. Hallyn
2022-08-15 2:32 ` Paul Moore
2022-08-15 15:41 ` Serge E. Hallyn
2022-08-15 16:24 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACYkzJ4_MrbS-2S_R3KSZnL8h9pWnP6ih5ccKPGYxZTaESMZ2g@mail.gmail.com \
--to=kpsingh@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=casey@schaufler-ca.com \
--cc=cgzones@googlemail.com \
--cc=daniel@iogearbox.net \
--cc=ebiederm@xmission.com \
--cc=eparis@parisplace.org \
--cc=fred@cloudflare.com \
--cc=jackmanb@chromium.org \
--cc=jmorris@namei.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=karl@bigbadwolfsecurity.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=revest@chromium.org \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=stephen.smalley.work@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).