From: mjg59@google.com (Matthew Garrett)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] integrity: silence warning when CONFIG_SECURITYFS is not enabled
Date: Mon, 4 Jun 2018 10:44:52 -0700 [thread overview]
Message-ID: <CACdnJutEmbHH1LQRFu1AJa0S1KTARLuSw1sb2D_WKMsepVEE0A@mail.gmail.com> (raw)
In-Reply-To: <1528121121-3959-1-git-send-email-sudeep.holla@arm.com>
On Mon, Jun 4, 2018 at 7:05 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
> When CONFIG_SECURITYFS is not enabled, securityfs_create_dir returns
> -ENODEV which throws the following error:
> "Unable to create integrity sysfs dir: -19"
>
> However, if the feature is disabled, it can't be warning and hence
> we need to silence the error.
I think it'd be preferable to check whether it's ENODEV rather than
doing IS_ENABLED. We should also reset integrity_dir to NULL rather
than leaving it as an error - it gets passed into various other
functions, and while those should all also just be returning errors
it'd be unfortunate if one attempted to dereference it.
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-06-04 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 14:05 [PATCH] integrity: silence warning when CONFIG_SECURITYFS is not enabled Sudeep Holla
2018-06-04 17:44 ` Matthew Garrett [this message]
2018-06-05 10:25 ` [PATCH v2] " Sudeep Holla
2018-06-05 14:49 ` Mimi Zohar
2018-06-06 9:23 ` Sudeep Holla
2018-06-06 13:24 ` Mimi Zohar
2018-06-06 21:07 ` Matthew Garrett
2018-06-13 15:00 ` [PATCH v3] " Sudeep Holla
2018-06-13 22:13 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACdnJutEmbHH1LQRFu1AJa0S1KTARLuSw1sb2D_WKMsepVEE0A@mail.gmail.com \
--to=mjg59@google.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).