From: mjg59@google.com (Matthew Garrett)
To: linux-security-module@vger.kernel.org
Subject: [PATCH V3 1/2] security: Add a cred_getsecid hook
Date: Mon, 30 Oct 2017 10:57:11 +0000 [thread overview]
Message-ID: <CACdnJuu8fvVoD+G50dWtauUUa3H1tUAbBgzusc_CKNBugrVmwQ@mail.gmail.com> (raw)
In-Reply-To: <1509027658.25604.4.camel@tycho.nsa.gov>
On Thu, Oct 26, 2017 at 3:20 PM, Stephen Smalley <sds@tycho.nsa.gov> wrote:
> On Thu, 2017-10-26 at 01:40 -0700, Matthew Garrett via Selinux wrote:
>> +static void selinux_cred_getsecid(const struct cred *c, u32 *secid)
>> +{
>> + rcu_read_lock();
>> + *secid = cred_sid(c);
>> + rcu_read_unlock();
>
> Is rcu_read_lock() necessary here? Seems like we use cred_sid() in many
> places without it.
Ah, I thought it was based on task_sid(), but I guess that's actually
protecting the __task_cred()?
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-30 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-26 8:40 [PATCH V3 1/2] security: Add a cred_getsecid hook Matthew Garrett
2017-10-26 8:40 ` [PATCH V3 2/2] IMA: Support using new creds in appraisal policy Matthew Garrett
2017-10-26 9:11 ` James Morris
2017-11-28 20:48 ` Mimi Zohar
2017-11-28 21:22 ` Matthew Garrett
2017-11-28 21:35 ` Mimi Zohar
2017-11-28 21:37 ` Matthew Garrett
2017-11-28 22:33 ` Mimi Zohar
2017-12-15 22:24 ` Matthew Garrett
2017-12-15 22:35 ` Matthew Garrett
2017-12-18 15:39 ` Mimi Zohar
2017-10-26 9:04 ` [PATCH V3 1/2] security: Add a cred_getsecid hook James Morris
2017-10-26 13:21 ` Casey Schaufler
2017-10-30 10:54 ` Matthew Garrett
2017-10-26 14:20 ` Stephen Smalley
2017-10-30 10:57 ` Matthew Garrett [this message]
2017-10-30 17:03 ` Stephen Smalley
2017-11-14 19:42 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACdnJuu8fvVoD+G50dWtauUUa3H1tUAbBgzusc_CKNBugrVmwQ@mail.gmail.com \
--to=mjg59@google.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).