From: Richard Hughes <hughsient@gmail.com>
To: Mario Limonciello <Mario.Limonciello@dell.com>
Cc: Platform Driver <platform-driver-x86@vger.kernel.org>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: Export LPC attributes for the system SPI chip
Date: Thu, 7 May 2020 19:47:29 +0100 [thread overview]
Message-ID: <CAD2FfiEk8Fq3=i_3NHvtuwip=-v_cGfnYSowdPi86U_BcgP2gQ@mail.gmail.com> (raw)
In-Reply-To: <aa217de398584fa7846cf4ac0c872036@AUSX13MPC101.AMER.DELL.COM>
On Thu, 7 May 2020 at 18:45, <Mario.Limonciello@dell.com> wrote:
> To echo Andy's question, I would wonder if it makes sense to just export
> these attributes in securityfs directly from the intel-spi-pci driver rather
> than to have another driver in platform-x86 to get the information.
The "DANGEROUS" in the SPI_INTEL_SPI_PCI and SPI_INTEL_SPI_PLATFORM
worried me somewhat. I'm guessing this is why most distros don't
compile it as a module by default. If the module isn't actually still
considered dangerous, and we can remove the warning I can of course
respin my patch on top of that instead.
Richard.
next prev parent reply other threads:[~2020-05-07 18:47 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 15:52 [PATCH] platform/x86: Export LPC attributes for the system SPI chip Richard Hughes
2020-05-06 16:29 ` Andy Shevchenko
2020-05-06 16:39 ` Richard Hughes
2020-05-07 17:05 ` Javier Martinez Canillas
2020-05-07 17:22 ` Andy Shevchenko
2020-05-07 17:28 ` Javier Martinez Canillas
2020-05-07 17:45 ` Mario.Limonciello
2020-05-07 18:47 ` Richard Hughes [this message]
2020-05-07 19:22 ` Mario.Limonciello
2020-05-07 19:49 ` Richard Hughes
2020-05-07 20:03 ` Mario.Limonciello
2020-05-08 8:20 ` Mika Westerberg
2020-05-08 16:15 ` Richard Hughes
2020-05-11 10:45 ` Mika Westerberg
2020-05-11 15:40 ` Richard Hughes
2020-05-11 16:28 ` Mika Westerberg
2020-05-11 20:08 ` Richard Hughes
2020-05-12 6:44 ` Mika Westerberg
2020-05-12 20:37 ` Richard Hughes
2020-05-08 17:27 ` Mario.Limonciello
2020-05-11 10:41 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD2FfiEk8Fq3=i_3NHvtuwip=-v_cGfnYSowdPi86U_BcgP2gQ@mail.gmail.com' \
--to=hughsient@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=linux-security-module@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).