Re: [PATCH] IMA: remove -Wmissing-prototypes warning

[Austin Kim <austindh.kim@gmail.com>]

2021년 6월 29일 (화) 오후 11:30, Mimi Zohar <zohar@linux.ibm.com>님이 작성:
>
> [Cc: Petko Manolov <petkan@mip-labs.com>]
>
> Hi Austin,
>
> On Tue, 2021-06-29 at 14:50 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@lge.com>
> >
> > With W=1 build, the compiler throws warning message as below:
> >
> >    security/integrity/ima/ima_mok.c:24:12: warning:
> >    no previous prototype for ‘ima_mok_init’ [-Wmissing-prototypes]
> >        __init int ima_mok_init(void)
> >
> > Silence the warning by adding static keyword to ima_mok_init().
> >
> > Signed-off-by: Austin Kim <austin.kim@lge.com>
> > ---
> >  security/integrity/ima/ima_mok.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/ima/ima_mok.c b/security/integrity/ima/ima_mok.c
> > index 1e5c01916173..95cc31525c57 100644
> > --- a/security/integrity/ima/ima_mok.c
> > +++ b/security/integrity/ima/ima_mok.c
> > @@ -21,7 +21,7 @@ struct key *ima_blacklist_keyring;
> >  /*
> >   * Allocate the IMA blacklist keyring
> >   */
> > -__init int ima_mok_init(void)
> > +static __init int ima_mok_init(void)
> >  {
> >       struct key_restriction *restriction;
> >
>
> Thank you for the patch, which does fix the warning.   The .ima_mok
> keyring was removed a while ago.  With all the recent work on the
> system blacklist, I'm wondering if anyone is still using the IMA
> blacklist keyring or whether it should be removed as well.

Oh! Thanks for information.

>
> thanks,
>
> Mimi
>