From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EF12770E6 for ; Thu, 9 May 2024 17:46:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715276763; cv=none; b=fuSQ0rm00lart5XIW+T7XDYM6z24QizaTv7M3qVaO8lq6hNobW/3UIQqVPqi/mE+88kgOVw66MjpnguwLdnUDr4pMN4rk6OkcUiPB8Ksbd6595+pnLUsDCYJPX1mcQqygCFhvIJroYNqht160zERp1WQCpVXTjqP+OSNlGslJjM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715276763; c=relaxed/simple; bh=/oSWOWjkap8fv/UuIsI6Isx0EXquObmcwzLznfIJKkQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SlcXOxukjJH1Z2odCciDVAFQ7wykaTAm3WdPOmhFxxshwqVDmBKjLeNFW2oTtd1nkGVLPFe8pvMoJWHJH62hKHvHPStMMO5Cz3jCODIB9IR0JQfw0anppbcKxHnND+VoVHWHNX87BGBnn42aVNuZCUmffrVp3LtfMnPMUfX/PWE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=fxjG3anD; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="fxjG3anD" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-572a1b3d6baso1202a12.1 for ; Thu, 09 May 2024 10:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715276760; x=1715881560; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=R9dUf6h0ZONDc1o4IvKX4JCSR1LfcFcW4NQit96LWug=; b=fxjG3anD83hFoJAGJtRblIDGAlzmSLRG8ntKPrhQt+HieXxnkLfNrfeXZDA4DRCfMe sREmIk4QaB74Bb5+DiGkytekIaBjk/rvNTyhi/v/+B08R+Q8xkpAkxzNLVstuVDGDd25 GEmOAe0DeZO+QlgQrqL3aR3rKTQi9U4Emep9ofkbHs2DXyOlZ4NdO4/806fVK2YkNxcS 68XAqfV/h5ZcRctT01utJ8bJz8tN/N7w4zhbOHBNLRylB0WWfQX5euwEKpNKnO8tR0BU G2FjQBn80cFSqwU79je9zjjKho3HbMYZc8xJ1oeIamcwBM68P2fSXUSvRXeo5wFqsQOv z1BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715276760; x=1715881560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R9dUf6h0ZONDc1o4IvKX4JCSR1LfcFcW4NQit96LWug=; b=ge61PC7R9d/373HF2Qj9H25pwpu4/ffP6IrWb8Is0Gmm8X/PbsfyKzl+oSuJPf/1WY o7UEYh7cW3y2Sk8LMqilZNoqn6g4FbutCwy5KYnfioXQiH4PpSnNdEt4zdNrgVqenyYX P+aJGLqEmWO/FLfKXHKROQgIEejlp6w4LNEfApOrQDHXzCH/3XgMWzxSTqVEt0N7tNMS srFBwGtmvaduaPJuCEEAELm4z16eBS7+bq5BaxngniVrzb52jk1BPWtA9D9snHYsYskj OrF4heLleXqIvA/TmoufoV8gGUvcotyqYm5/BJQYKjBVf736Wra9oMw0SophbExq7tuR j6lQ== X-Forwarded-Encrypted: i=1; AJvYcCWRm5aGhuyVqqu1Jviwnt8Vp8LKr2doikozNifU1LjKH9ERaHuGRN0tItimEUqcCdi5EvgeOntTCNMvVIkkmBlhbNVOX6WsHuehn0Pof82oeEGZDetW X-Gm-Message-State: AOJu0YwUa3HbOMNndT5nJ+8sL7GlFBq0fIUtM3pxazQF2BBjCMpznEWF uPJSuXhTDEUYhkVWYp9Ba2auMRmDTAA/7+NXIy72X6AEEoZb2s5DdNVX7e7dWoyYYBlDaJ0xRSY WTG5RRk1117lv0H/zwl+htZyFIIOWtXT2qu6O X-Google-Smtp-Source: AGHT+IFG+qZVP+GdGsJ0bfuXNwufKAJIRBglqYr60vsLU06TQKxk62S9P+fDwyd1v4jS3rVgg+dEQp+BJ2xOYW96LJk= X-Received: by 2002:a50:cac7:0:b0:572:988f:2f38 with SMTP id 4fb4d7f45d1cf-5734f8fe9f6mr3018a12.6.1715276759326; Thu, 09 May 2024 10:45:59 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> In-Reply-To: <946ae22f-a4af-448a-92e1-60afb6ed9261@linuxfoundation.org> From: Edward Liaw Date: Thu, 9 May 2024 10:45:31 -0700 Message-ID: Subject: Re: [PATCH v2 0/5] Define _GNU_SOURCE for sources using To: Shuah Khan Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 9, 2024 at 7:37=E2=80=AFAM Shuah Khan wrote: > > On 5/9/24 00:13, Edward Liaw wrote: > > On Wed, May 8, 2024 at 4:10=E2=80=AFPM Shuah Khan wrote: > >> > >> On 5/7/24 15:38, Edward Liaw wrote: > >>> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced > >>> asprintf into kselftest_harness.h, which is a GNU extension and needs > >>> _GNU_SOURCE to either be defined prior to including headers or with t= he > >>> -D_GNU_SOURCE flag passed to the compiler. > >>> > >>> v1: https://lore.kernel.org/linux-kselftest/20240430235057.1351993-1-= edliaw@google.com/ > >>> v2: add -D_GNU_SOURCE to KHDR_INCLUDES so that it is in a single > >>> location. Remove #define _GNU_SOURCE from source code to resolve > >>> redefinition warnings. > >>> > >>> Edward Liaw (5): > >>> selftests: Compile kselftest headers with -D_GNU_SOURCE > >>> selftests/sgx: Include KHDR_INCLUDES in Makefile > >> > >> I appled patches 1/5 and 2.5 - The rest need to be split up. > >> > >>> selftests: Include KHDR_INCLUDES in Makefile > >>> selftests: Drop define _GNU_SOURCE > >>> selftests: Drop duplicate -D_GNU_SOURCE > >>> > >> > >> Please split these patches pwe test directory. Otherwise it will > >> cause merge conflicts which can be hard to resolve. > > > > Hi Shuah, > > Sean asked that I rebase the patches on linux-next, and I will need to > > remove additional _GNU_SOURCE defines. Should I send an unsplit v3 to > > be reviewed, then split it afterwards? I'm concerned that it will be > > difficult to review with ~70 patches once split. > > Please send them split - it will be easier to review and apply. You > might as well wait until the merge window is done. I don't think > anybody would have time to review now since merge window starts > next week. Sorry, I have them split already; is it ok if I send them now? I will be on leave soon and may not be able to get back to it in a while. Thanks, Edward > > > thanks, > -- Shuah