From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA423130AFC for ; Wed, 8 May 2024 20:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715200093; cv=none; b=XlSrFiWEpdeBG4hnxPJupGBOLHhSsMsvC259kBw6l6qOU1TXvCvbmsyXWmdi5D2vHXWZWA08eyKAI9GB5zefE/HjvWJw3NcrZP2uGfXWW6fkzbAipeAmIb4EoTboH3ob2nSnYrxaGChra8a2pQojl/zsej7UDi7XuxzVF4kLwts= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715200093; c=relaxed/simple; bh=o2NLQhPztuDZ4rTiTDFMEINRFzrqOs93EXYAp0RXtiY=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=JBhMpzWwXLohbGC/mBZziO6YIq2/mDEegbPyolgD8CeM5vPdHUrfL9bJvNmnG6eNvVSb/4CufGfdVBarfEG3y6BtmT7ve1j6wXkGN3GgYwUCHwCuYXs6Nb8gztBm4IrG/AzyUsD+L6zS+x3UNMBgsqHgwKWDF13m80NUN5UY9SM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NyX9IHCr; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NyX9IHCr" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-572aad902baso3802a12.0 for ; Wed, 08 May 2024 13:28:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715200088; x=1715804888; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VxBCT1ZV/EGWLKjxVs7FXcKu7sqjJfkKsVJ1w+mU1+0=; b=NyX9IHCrSC9Je83Z/MnO8GwYzmpBLZE12Oh7P0WFKvTalU2Ciei+SR4yfrdbmQXps+ uWt/vjgQ+p0u6FKAcDDdqRciXtxpn1eAn1RRbxJrfD7/D6dUWWiyHNmgyOHtkeETq02t YGSf7tHygxWbjyaDE4tFQH/tNyN+kiFydGC4Sf/vS3eO7m6sUlailV45R5eKKxcUYq0J aW/UI7mnxqPAUJ+IEgeMuC8o5GtFG8x1++zBxQVDeD5vc9pjheIIRF7IN7vbtVWA/fD2 KDdFmbJEMXi4XdMUBM8YFeX7KpKa9V5dExWXQepqMrbkr5Fy3psYGVyoCv4bI3hNGEoQ uD6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715200088; x=1715804888; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VxBCT1ZV/EGWLKjxVs7FXcKu7sqjJfkKsVJ1w+mU1+0=; b=bSrTVuEW/hznCc7nUkJB37ifQI60YSmhv9XlHg+WSPW/35BcK9gV44DwJob62ASXcL tMYqPAnzUxxY5vCsODZPOYkUwKhAfVLr2szvHmcCnj3aNlFwz8El5HcfrJnpCgP8T62S xOf8e0essfN4cIi6dG77K0sfViVgf5PK9H3hahnyLG9bzeiJ4O9PIt4CoyYoITyGvAJi vPRbTkWBOD/0XykSieHhXnKeVDOxezImQd02WdQUHNHGl6qyalrn50SmkQ0Mp88Y1+BE pKcBSutZ0ijoofqJG+zFZXp95TWUKx7Rgq3voZiZVEeRaxjLY26hjEhMNYgM2dxP8o6x KhXA== X-Forwarded-Encrypted: i=1; AJvYcCVwY4YM7WnO8i6EjN057pM9DDKXT1RN34VJN0kokRx5iPb9v7KQmu4zZRyiatOPxFFO5uutP5wjBq94JGDqIjD9hLMqpetvvw751E26GQHaua1/q1/e X-Gm-Message-State: AOJu0YxYHi2DAV/k5hPxYQ/LZAnGTh4JQ8lKg3tYKp/0gberEvbimLmd fmnzDxr9C1t14wdyyyQy6Dyca+qdUZOmkYzRtDdBZRqzphsEFUbLBF1NadofUa3ue088L6rRi7C IG3myITs8lz3APGIHB4sF8EN0GTLGoL4K7vc6 X-Google-Smtp-Source: AGHT+IG0Nkg3RjjAAyj+n+Ew0xyy8RnKsH20og6+OrFEWYycNhxXEo9VK176FECewK/2EQxZ5XFepnMJQqWDZY6gYdE= X-Received: by 2002:a05:6402:228b:b0:572:a33d:437f with SMTP id 4fb4d7f45d1cf-573341614e1mr44879a12.2.1715200087751; Wed, 08 May 2024 13:28:07 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-security-module@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-5-edliaw@google.com> In-Reply-To: From: Edward Liaw Date: Wed, 8 May 2024 13:27:39 -0700 Message-ID: Subject: Re: [PATCH v2 4/5] selftests: Drop define _GNU_SOURCE To: Sean Christopherson Cc: shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen , Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, May 8, 2024 at 6:54=E2=80=AFAM Sean Christopherson wrote: > > On Tue, May 07, 2024, Edward Liaw wrote: > > _GNU_SOURCE is provided by KHDR_INCLUDES, so it should be dropped to > > prevent _GNU_SOURCE redefined warnings. > > ... > > > diff --git a/tools/testing/selftests/x86/test_syscall_vdso.c b/tools/te= sting/selftests/x86/test_syscall_vdso.c > > index 8965c311bd65..5cd13279bba5 100644 > > --- a/tools/testing/selftests/x86/test_syscall_vdso.c > > +++ b/tools/testing/selftests/x86/test_syscall_vdso.c > > @@ -8,10 +8,6 @@ > > * Can be built statically: > > * gcc -Os -Wall -static -m32 test_syscall_vdso.c thunks_32.S > > */ > > -#undef _GNU_SOURCE > > -#define _GNU_SOURCE 1 > > -#undef __USE_GNU > > -#define __USE_GNU 1 > > AFAICT, manually defining __USE_GNU is frowned upon, so I'm guessing the = __USE_GNU > stuff is just the result of misguided copy+paste. But it would be nice t= o get > confirmation that this test isn't doing something clever. Or at the very= least, > explain the removal of __USE_GNU in the changelog. It looks like test_syscall_vdso, test_FCMOV, test_FCOMI, and test_FISTTP don't actually use any GNU extensions. I'll add that to the commit message. > > > #include > > #include > > #include