Re: TSEM code organization.

[Paul Moore <paul@paul-moore.com>]

On Sat, Mar 16, 2024 at 6:47 AM Dr. Greg <greg@enjellic.com> wrote:
>
> Good morning Paul, I hope your weekend is going well or your week is
> starting well, whenever this e-mail finds you.
>
> We've been waiting for the release of 6.8 for the V3 release of TSEM.
> TSEM seems to be co-habitating with it reasonably well, modulo some
> atomic structure magazine refill issues we are sorting out that appear
> to be caused by workqueue scheduling latency differences between this
> kernel and older kernels, so we are getting ready to push the V3
> release.
>
> Casey has previously raised an issue with the fact that we used a
> single include file, tsem.h, for all of the entities that are global
> to the various compilation units.  We placed that file first in the
> patch series so that it could be referenced for review as the
> individual compilation units were added ...

Considering that there are still a number of concerns around the
design of TSEM I wouldn't worry too much about the smaller, easier to
change implementation details, like header file organization at this
point in time.  If you've got something that is functional, that
should be sufficient.  We still need to sort out if the basic design
and TSEM concepts are acceptable upstream.

-- 
paul-moore.com