From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C2DC43334 for ; Sat, 16 Jul 2022 03:33:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230315AbiGPDdY (ORCPT ); Fri, 15 Jul 2022 23:33:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbiGPDdY (ORCPT ); Fri, 15 Jul 2022 23:33:24 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9566932D86 for ; Fri, 15 Jul 2022 20:33:21 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id r2so8152183wrs.3 for ; Fri, 15 Jul 2022 20:33:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vYR3WbTFw4TG1sTb7Tx0DmmRBxroaabfz9k7MAvXkH8=; b=k7qQPhMi60UEu2t7Hy049XBotEoKQQS4zKTvIZbjutCVW3oOPDzfx/tdLWSNpBnAuk Qr/jpVC/tkzaqBgeT7DhsxNRpddneFPr3lGnPMdRZ/fGzqTxOFFowlSmNl0f0yiNCaQ7 KZJdZiyJvNaLfDBguZfb3B7tsLe1EfdJeZfL4jgVhJEKCKAhUFGFj/sqH9QC8ChW0wyx 7WALWpRiTCSmJ+8hllhUoERb9LdVasszLNciNqU1jLpTCCcbZ4lJkMXJRTIyFs9jgJPO od5s4hxPHJN/vuFDpKdYJFXkhyMsKp53LyJ41wKjw3fRXmiA/Q6pISDX8GV1EJSRthLX ETrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vYR3WbTFw4TG1sTb7Tx0DmmRBxroaabfz9k7MAvXkH8=; b=j+U08WxfF9r40U9xjX4ZTyDE8eQouvWJKaf6SHT5qwq82D8zeRNpXK7byLVbu6Qa4E Vgu2axJVC/Fj5uSJkooOgagIgqfdhn9TNu7VO+1WEs0iW6kyfs9UCKZFYMquzuvucGil mx4Wp4hBgNY5vR5nzKia7Z6ZRQV0puA43+BPINZlp+mDlkB4sKGjm9dTl598XURY3dkE Iuqo2I6NlbOutHQOa9Q28b1NoAX35Twk0GrY82dcETmJcCamBJQXXm9AxZ7P19ERu0l7 V2noKhBZZcaJvmZXkttCiZf+XboPGftJ1ca9jzq+thnhfOou26RRVZnmfuErC0qlpcL7 Igig== X-Gm-Message-State: AJIora8f4N44dtFYZ325fsArh//3ttHeInhfIVD4crXBXm8rhp506ixu QlIZieH2FQnymTWPBx6cueAkH4fcM3LpokwiQ5C2 X-Google-Smtp-Source: AGRyM1tBYotr89sxZgUpj7Rz0paH0nzxUS6pduI0qUwqAk5vOCrzC6ovujPmRSHKTDcGuNMqQfswDSvUMwdMgE31v98= X-Received: by 2002:adf:d22f:0:b0:21d:6b26:8c6f with SMTP id k15-20020adfd22f000000b0021d6b268c6fmr15647822wrh.70.1657942400130; Fri, 15 Jul 2022 20:33:20 -0700 (PDT) MIME-Version: 1.0 References: <20220715191622.2310436-1-mcgrof@kernel.org> In-Reply-To: From: Paul Moore Date: Fri, 15 Jul 2022 23:33:08 -0400 Message-ID: Subject: Re: [PATCH v2] lsm,io_uring: add LSM hooks for the new uring_cmd file op To: Jens Axboe , Luis Chamberlain Cc: casey@schaufler-ca.com, joshi.k@samsung.com, linux-security-module@vger.kernel.org, io-uring@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, a.manzanares@samsung.com, javier@javigon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: On Fri, Jul 15, 2022 at 3:52 PM Paul Moore wrote: > On Fri, Jul 15, 2022 at 3:28 PM Jens Axboe wrote: > > On 7/15/22 1:16 PM, Luis Chamberlain wrote: > > > io-uring cmd support was added through ee692a21e9bf ("fs,io_uring: > > > add infrastructure for uring-cmd"), this extended the struct > > > file_operations to allow a new command which each subsystem can use > > > to enable command passthrough. Add an LSM specific for the command > > > passthrough which enables LSMs to inspect the command details. > > > > > > This was discussed long ago without no clear pointer for something > > > conclusive, so this enables LSMs to at least reject this new file > > > operation. > > > > From an io_uring perspective, this looks fine to me. It may be easier if > > I take this through my tree due to the moving of the files, or the > > security side can do it but it'd have to then wait for merge window (and > > post io_uring branch merge) to do so. Just let me know. If done outside > > of my tree, feel free to add: I forgot to add this earlier ... let's see how the timing goes, I don't expect the LSM/Smack/SELinux bits to be ready and tested before the merge window opens so I'm guessing this will not be an issue in practice, but thanks for the heads-up. -- paul-moore.com