From: Paul Moore <paul@paul-moore.com>
To: Sergey Nazarov <s-nazarov@yandex.ru>
Cc: linux-security-module@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, Ondrej Mosnacek <omosnace@redhat.com>
Subject: Re: [PATCH v2] CIPSO: Fix unaligned memory access in cipso_v4_gentag_hdr
Date: Fri, 5 Mar 2021 11:42:33 -0500 [thread overview]
Message-ID: <CAHC9VhQy2Z512Qy2EVaoc_XMewS0bhH12VJU0SxgK3pSy0ub8Q@mail.gmail.com> (raw)
In-Reply-To: <962223cc9f1cd71814c66f563e35f53cc220f5ce.camel@yandex.ru>
On Fri, Mar 5, 2021 at 3:05 AM Sergey Nazarov <s-nazarov@yandex.ru> wrote:
>
> We need to use put_unaligned when writing 32-bit DOI value
> in cipso_v4_gentag_hdr to avoid unaligned memory access.
>
> v2: unneeded type cast removed as Ondrej Mosnacek suggested.
>
> Signed-off-by: Sergey Nazarov <s-nazarov@yandex.ru>
> ---
> net/ipv4/cipso_ipv4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Paul Moore <paul@paul-moore.com>
> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index 471d33a..6e59902 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -1162,7 +1162,7 @@ static void cipso_v4_gentag_hdr(const struct
> cipso_v4_doi *doi_def,
> {
> buf[0] = IPOPT_CIPSO;
> buf[1] = CIPSO_V4_HDR_LEN + len;
> - *(__be32 *)&buf[2] = htonl(doi_def->doi);
> + put_unaligned_be32(doi_def->doi, &buf[2]);
> }
>
> /**
> --
> 1.8.3.1
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2021-03-05 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 8:05 [PATCH v2] CIPSO: Fix unaligned memory access in cipso_v4_gentag_hdr Sergey Nazarov
2021-03-05 16:42 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhQy2Z512Qy2EVaoc_XMewS0bhH12VJU0SxgK3pSy0ub8Q@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=davem@davemloft.net \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=omosnace@redhat.com \
--cc=s-nazarov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).