* [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys @ 2023-06-21 7:46 Gaosheng Cui 2023-06-21 13:33 ` Paul Moore 0 siblings, 1 reply; 7+ messages in thread From: Gaosheng Cui @ 2023-06-21 7:46 UTC (permalink / raw) To: jejb, jarkko, zohar, dhowells, paul, jmorris, serge, cuigaosheng1 Cc: linux-integrity, keyrings, linux-security-module Fix kernel-doc warnings in trusted-keys: security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting prototype for tpm_buf_append_auth(). Prototype was for tpm2_buf_append_auth() instead. Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- security/keys/trusted-keys/trusted_tpm2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/keys/trusted-keys/trusted_tpm2.c b/security/keys/trusted-keys/trusted_tpm2.c index 2b2c8eb258d5..bc700f85f80b 100644 --- a/security/keys/trusted-keys/trusted_tpm2.c +++ b/security/keys/trusted-keys/trusted_tpm2.c @@ -186,7 +186,7 @@ int tpm2_key_priv(void *context, size_t hdrlen, } /** - * tpm_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer. + * tpm2_buf_append_auth() - append TPMS_AUTH_COMMAND to the buffer. * * @buf: an allocated tpm_buf instance * @session_handle: session handle -- 2.25.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-06-21 7:46 [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys Gaosheng Cui @ 2023-06-21 13:33 ` Paul Moore 2023-07-25 20:49 ` Paul Moore 0 siblings, 1 reply; 7+ messages in thread From: Paul Moore @ 2023-06-21 13:33 UTC (permalink / raw) To: Gaosheng Cui Cc: jejb, jarkko, zohar, dhowells, jmorris, serge, linux-integrity, keyrings, linux-security-module On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > Fix kernel-doc warnings in trusted-keys: > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > prototype for tpm_buf_append_auth(). Prototype was for > tpm2_buf_append_auth() instead. > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Paul Moore <paul@paul-moore.com> -- paul-moore.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-06-21 13:33 ` Paul Moore @ 2023-07-25 20:49 ` Paul Moore 2023-08-03 22:00 ` Paul Moore 0 siblings, 1 reply; 7+ messages in thread From: Paul Moore @ 2023-07-25 20:49 UTC (permalink / raw) To: Gaosheng Cui, jarkko, dhowells Cc: jejb, zohar, jmorris, serge, linux-integrity, keyrings, linux-security-module On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > Fix kernel-doc warnings in trusted-keys: > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > prototype for tpm_buf_append_auth(). Prototype was for > > tpm2_buf_append_auth() instead. > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > --- > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Reviewed-by: Paul Moore <paul@paul-moore.com> Jarkko, David, can one of you pick this up into your tree? -- paul-moore.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-07-25 20:49 ` Paul Moore @ 2023-08-03 22:00 ` Paul Moore 2023-08-03 22:20 ` Mimi Zohar 0 siblings, 1 reply; 7+ messages in thread From: Paul Moore @ 2023-08-03 22:00 UTC (permalink / raw) To: Gaosheng Cui, jarkko, dhowells Cc: jejb, zohar, jmorris, serge, linux-integrity, keyrings, linux-security-module On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > prototype for tpm_buf_append_auth(). Prototype was for > > > tpm2_buf_append_auth() instead. > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > --- > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > Jarkko, David, can one of you pick this up into your tree? Guys, this patch is both trivial and obviously correct, please pick it up so it can go up during the next merge window. -- paul-moore.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-08-03 22:00 ` Paul Moore @ 2023-08-03 22:20 ` Mimi Zohar 2023-08-03 23:20 ` Paul Moore 0 siblings, 1 reply; 7+ messages in thread From: Mimi Zohar @ 2023-08-03 22:20 UTC (permalink / raw) To: Paul Moore, Gaosheng Cui, jarkko, dhowells Cc: jejb, jmorris, serge, linux-integrity, keyrings, linux-security-module On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > tpm2_buf_append_auth() instead. > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > --- > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > Jarkko, David, can one of you pick this up into your tree? > > Guys, this patch is both trivial and obviously correct, please pick it > up so it can go up during the next merge window. Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't on the top of Jarkko's radar, I'll queue it. Mimi ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-08-03 22:20 ` Mimi Zohar @ 2023-08-03 23:20 ` Paul Moore 2023-08-04 11:57 ` Mimi Zohar 0 siblings, 1 reply; 7+ messages in thread From: Paul Moore @ 2023-08-03 23:20 UTC (permalink / raw) To: Mimi Zohar Cc: Gaosheng Cui, jarkko, dhowells, jejb, jmorris, serge, linux-integrity, keyrings, linux-security-module On Thu, Aug 3, 2023 at 6:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote: > > On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > > tpm2_buf_append_auth() instead. > > > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > > --- > > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > > > Jarkko, David, can one of you pick this up into your tree? > > > > Guys, this patch is both trivial and obviously correct, please pick it > > up so it can go up during the next merge window. > > Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't > on the top of Jarkko's radar, I'll queue it. Ah ha! I was working under the assumption that everything under security/keys/ was David and Jarko's responsibility, but now that I'm looking at MAINTAINERS I see that isn't the case. In fact it looks like there are five (!) different "subsystems" under security/keys/ ... I don't currently know enough about the different divisions there, but it seems like we might want to see if we can do some consolidation ... Anyway, thanks for picking this up Mimi. -- paul-moore.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys 2023-08-03 23:20 ` Paul Moore @ 2023-08-04 11:57 ` Mimi Zohar 0 siblings, 0 replies; 7+ messages in thread From: Mimi Zohar @ 2023-08-04 11:57 UTC (permalink / raw) To: Paul Moore, Steven Rostedt (Google) Cc: Gaosheng Cui, jarkko, dhowells, jejb, jmorris, serge, linux-integrity, keyrings, linux-security-module On Thu, 2023-08-03 at 19:20 -0400, Paul Moore wrote: > On Thu, Aug 3, 2023 at 6:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote: > > > > On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote: > > > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote: > > > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote: > > > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote: > > > > > > > > > > > > Fix kernel-doc warnings in trusted-keys: > > > > > > > > > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting > > > > > > prototype for tpm_buf_append_auth(). Prototype was for > > > > > > tpm2_buf_append_auth() instead. > > > > > > > > > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > > > > > --- > > > > > > security/keys/trusted-keys/trusted_tpm2.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > Reviewed-by: Paul Moore <paul@paul-moore.com> > > > > > > > > Jarkko, David, can one of you pick this up into your tree? > > > > > > Guys, this patch is both trivial and obviously correct, please pick it > > > up so it can go up during the next merge window. > > > > Paul, either Jarkko or I can queue a trusted-keys patch. As this isn't > > on the top of Jarkko's radar, I'll queue it. > > Ah ha! I was working under the assumption that everything under > security/keys/ was David and Jarko's responsibility, but now that I'm > looking at MAINTAINERS I see that isn't the case. In fact it looks > like there are five (!) different "subsystems" under security/keys/ > ... I don't currently know enough about the different divisions there, > but it seems like we might want to see if we can do some consolidation > ... > > Anyway, thanks for picking this up Mimi. Thanks, Steven. "6c95d71bad61 tracing: Fix kernel-doc warnings in trace_seq.c " is in Linus' tree. Mimi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-08-04 11:57 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-06-21 7:46 [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys Gaosheng Cui 2023-06-21 13:33 ` Paul Moore 2023-07-25 20:49 ` Paul Moore 2023-08-03 22:00 ` Paul Moore 2023-08-03 22:20 ` Mimi Zohar 2023-08-03 23:20 ` Paul Moore 2023-08-04 11:57 ` Mimi Zohar
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).