linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Mimi Zohar <zohar@linux.ibm.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>,
	jarkko@kernel.org, dhowells@redhat.com, jejb@linux.ibm.com,
	jmorris@namei.org, serge@hallyn.com,
	linux-integrity@vger.kernel.org, keyrings@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys
Date: Thu, 3 Aug 2023 19:20:16 -0400	[thread overview]
Message-ID: <CAHC9VhRQBOfdcYO5QLRgVGdbqLFrogXeVD3FT2cETmLhP5uz3A@mail.gmail.com> (raw)
In-Reply-To: <31a5aed2f075b69705142ff6f558e8cd8ccb9cd8.camel@linux.ibm.com>

On Thu, Aug 3, 2023 at 6:21 PM Mimi Zohar <zohar@linux.ibm.com> wrote:
>
> On Thu, 2023-08-03 at 18:00 -0400, Paul Moore wrote:
> > On Tue, Jul 25, 2023 at 4:49 PM Paul Moore <paul@paul-moore.com> wrote:
> > > On Wed, Jun 21, 2023 at 9:33 AM Paul Moore <paul@paul-moore.com> wrote:
> > > > On Wed, Jun 21, 2023 at 3:46 AM Gaosheng Cui <cuigaosheng1@huawei.com> wrote:
> > > > >
> > > > > Fix kernel-doc warnings in trusted-keys:
> > > > >
> > > > > security/keys/trusted-keys/trusted_tpm2.c:203: warning: expecting
> > > > > prototype for tpm_buf_append_auth(). Prototype was for
> > > > > tpm2_buf_append_auth() instead.
> > > > >
> > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> > > > > ---
> > > > >  security/keys/trusted-keys/trusted_tpm2.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Reviewed-by: Paul Moore <paul@paul-moore.com>
> > >
> > > Jarkko, David, can one of you pick this up into your tree?
> >
> > Guys, this patch is both trivial and obviously correct, please pick it
> > up so it can go up during the next merge window.
>
> Paul, either Jarkko or I can queue a trusted-keys patch.  As this isn't
> on the top of Jarkko's radar, I'll queue it.

Ah ha!  I was working under the assumption that everything under
security/keys/ was David and Jarko's responsibility, but now that I'm
looking at MAINTAINERS I see that isn't the case.  In fact it looks
like there are five (!) different "subsystems" under security/keys/
... I don't currently know enough about the different divisions there,
but it seems like we might want to see if we can do some consolidation
...

Anyway, thanks for picking this up Mimi.

-- 
paul-moore.com

  reply	other threads:[~2023-08-03 23:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21  7:46 [PATCH -next] trusted-keys: Fix kernel-doc warnings in trusted-keys Gaosheng Cui
2023-06-21 13:33 ` Paul Moore
2023-07-25 20:49   ` Paul Moore
2023-08-03 22:00     ` Paul Moore
2023-08-03 22:20       ` Mimi Zohar
2023-08-03 23:20         ` Paul Moore [this message]
2023-08-04 11:57           ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHC9VhRQBOfdcYO5QLRgVGdbqLFrogXeVD3FT2cETmLhP5uz3A@mail.gmail.com \
    --to=paul@paul-moore.com \
    --cc=cuigaosheng1@huawei.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).